From commits-return-15248-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org  Sat Jul 27 16:47:27 2019
Return-Path: <commits-return-15248-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id B677318064E
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 27 Jul 2019 18:47:26 +0200 (CEST)
Received: (qmail 5729 invoked by uid 500); 27 Jul 2019 16:47:26 -0000
Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pdfbox.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pdfbox.apache.org>
List-Post: <mailto:commits@pdfbox.apache.org>
List-Id: <commits.pdfbox.apache.org>
Reply-To: dev@pdfbox.apache.org
Delivered-To: mailing list commits@pdfbox.apache.org
Received: (qmail 5720 invoked by uid 99); 27 Jul 2019 16:47:26 -0000
Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jul 2019 16:47:26 +0000
Received: from svn01-us-west.apache.org (localhost [127.0.0.1])
	by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 558053A3866
	for <commits@pdfbox.apache.org>; Sat, 27 Jul 2019 16:47:25 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1863877 - in /pdfbox/branches/issue45:
 fontbox/src/main/java/org/apache/fontbox/cff/
 pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/prepress/
 pdfbox/src/main/java/org/apache/pdfbox/util/
Date: Sat, 27 Jul 2019 16:47:25 -0000
To: commits@pdfbox.apache.org
From: tilman@apache.org
X-Mailer: svnmailer-1.0.9
Message-Id: <20190727164725.558053A3866@svn01-us-west.apache.org>

Author: tilman
Date: Sat Jul 27 16:47:25 2019
New Revision: 1863877

URL: http://svn.apache.org/viewvc?rev=1863877&view=rev
Log:
PDFBOX-4071: SonarQube fix

Modified:
    pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/DataInput.java
    pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/prepress/PDBoxStyle.java
    pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/util/Matrix.java

Modified: pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/DataInput.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/DataInput.java?rev=1863877&r1=1863876&r2=1863877&view=diff
==============================================================================
--- pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/DataInput.java (original)
+++ pdfbox/branches/issue45/fontbox/src/main/java/org/apache/fontbox/cff/DataInput.java Sat Jul 27 16:47:25 2019
@@ -207,8 +207,7 @@ public class DataInput
     {
         try
         {
-            int value = inputBuffer[bufferPosition + offset] & 0xff;
-            return value;
+            return inputBuffer[bufferPosition + offset] & 0xff;
         }
         catch (RuntimeException re)
         {

Modified: pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/prepress/PDBoxStyle.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/prepress/PDBoxStyle.java?rev=1863877&r1=1863876&r2=1863877&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/prepress/PDBoxStyle.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/prepress/PDBoxStyle.java Sat Jul 27 16:47:25 2019
@@ -90,8 +90,7 @@ public class PDBoxStyle implements COSOb
             colorValues.add( COSInteger.ZERO );
             dictionary.setItem(COSName.C, colorValues);
         }
-        PDColor color = new PDColor(colorValues.toFloatArray(), PDDeviceRGB.INSTANCE);
-        return color;
+        return new PDColor(colorValues.toFloatArray(), PDDeviceRGB.INSTANCE);
     }
 
     /**

Modified: pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/util/Matrix.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/util/Matrix.java?rev=1863877&r1=1863876&r2=1863877&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/util/Matrix.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/util/Matrix.java Sat Jul 27 16:47:25 2019
@@ -719,14 +719,13 @@ public final class Matrix implements Clo
     @Override
     public String toString()
     {
-        String sb = "" + "[" +
-                single[0] + "," +
-                single[1] + "," +
-                single[3] + "," +
-                single[4] + "," +
-                single[6] + "," +
-                single[7] + "]";
-        return sb;
+        return "[" +
+            single[0] + "," +
+            single[1] + "," +
+            single[3] + "," +
+            single[4] + "," +
+            single[6] + "," +
+            single[7] + "]";
     }
 
     @Override