pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1861407 - /pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
Date Sat, 15 Jun 2019 16:12:13 GMT
Author: tilman
Date: Sat Jun 15 16:12:13 2019
New Revision: 1861407

URL: http://svn.apache.org/viewvc?rev=1861407&view=rev
Log:
PDFBOX-4071: SonarQube fix

Modified:
    pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java

Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java?rev=1861407&r1=1861406&r2=1861407&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
(original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
Sat Jun 15 16:12:13 2019
@@ -167,7 +167,7 @@ public class ErrorDialog extends JDialog
                 {
                     if (details == null)
                     {
-                        details = createDetailedMessage(error);
+                        details = createDetailedMessage();
                         StringBuilder buffer = new StringBuilder();
                         stacktrace.setText(generateStackTrace(error, buffer).toString());
                         stacktrace.setCaretPosition(0);
@@ -247,14 +247,13 @@ public class ErrorDialog extends JDialog
     /**
      * Creates a non-editable widget to display the detailed stack trace.
      */
-    JScrollPane createDetailedMessage(Throwable t)
+    JScrollPane createDetailedMessage()
     {
         stacktrace = new JTextPane();
         stacktrace.setEditable(false);
-        JScrollPane pane = new JScrollPane(stacktrace,
+        return new JScrollPane(stacktrace,
                 JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED,
                 JScrollPane.HORIZONTAL_SCROLLBAR_AS_NEEDED);
-        return pane;
     }
 
     /**



Mime
View raw message