From commits-return-14507-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Thu Apr 11 16:34:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BEDEC18065D for ; Thu, 11 Apr 2019 18:34:04 +0200 (CEST) Received: (qmail 91605 invoked by uid 500); 11 Apr 2019 16:34:04 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 91594 invoked by uid 99); 11 Apr 2019 16:34:03 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Apr 2019 16:34:03 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 82A7A3A005C for ; Thu, 11 Apr 2019 16:34:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1857351 - /pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java Date: Thu, 11 Apr 2019 16:34:03 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190411163403.82A7A3A005C@svn01-us-west.apache.org> Author: tilman Date: Thu Apr 11 16:34:03 2019 New Revision: 1857351 URL: http://svn.apache.org/viewvc?rev=1857351&view=rev Log: PDFBOX-3017: crawl whole field tree and not just root Modified: pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java Modified: pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java?rev=1857351&r1=1857350&r2=1857351&view=diff ============================================================================== --- pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java (original) +++ pdfbox/branches/issue45/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java Thu Apr 11 16:34:03 2019 @@ -77,8 +77,7 @@ public class PDSignatureField extends PD { String fieldName = "Signature"; Set sigNames = new HashSet(); - // fixme: this ignores non-terminal fields, so will miss any descendant signatures - for (PDField field : getAcroForm().getFields()) + for (PDField field : getAcroForm().getFieldTree()) { if(field instanceof PDSignatureField) {