From commits-return-14476-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Tue Apr 9 11:43:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 461E3180629 for ; Tue, 9 Apr 2019 13:43:20 +0200 (CEST) Received: (qmail 36424 invoked by uid 500); 9 Apr 2019 11:23:42 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 36415 invoked by uid 99); 9 Apr 2019 11:23:42 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 11:23:42 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id E40E03A2D46 for ; Tue, 9 Apr 2019 11:43:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1857171 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java Date: Tue, 09 Apr 2019 11:43:18 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190409114318.E40E03A2D46@svn01-us-west.apache.org> Author: tilman Date: Tue Apr 9 11:43:18 2019 New Revision: 1857171 URL: http://svn.apache.org/viewvc?rev=1857171&view=rev Log: PDFBOX-4509: SonarQube fix Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java?rev=1857171&r1=1857170&r2=1857171&view=diff ============================================================================== --- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java (original) +++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDResources.java Tue Apr 9 11:43:18 2019 @@ -713,12 +713,10 @@ public final class PDResources implement { for (Map.Entry entry : dict.entrySet()) { - if (entry.getValue() instanceof COSObject) + if (entry.getValue() instanceof COSObject && + object.getCOSObject() == ((COSObject) entry.getValue()).getObject()) { - if (object.getCOSObject() == ((COSObject) entry.getValue()).getObject()) - { - return entry.getKey(); - } + return entry.getKey(); } } }