pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1854634 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java
Date Sat, 02 Mar 2019 10:01:15 GMT
Author: tilman
Date: Sat Mar  2 10:01:15 2019
New Revision: 1854634

URL: http://svn.apache.org/viewvc?rev=1854634&view=rev
Log:
PDFBOX-4477: add comment for later

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java?rev=1854634&r1=1854633&r2=1854634&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFCloneUtility.java Sat
Mar  2 10:01:15 2019
@@ -44,6 +44,9 @@ class PDFCloneUtility
     private final PDDocument destination;
     private final Map<Object,COSBase> clonedVersion = new HashMap<>();
     private final Set<COSBase> clonedValues = new HashSet<>();
+    // It might be useful to use IdentityHashMap like in PDFBOX-4477 for speed,
+    // but we need a really huge file to test this. A test with the file from PDFBOX-4477
+    // did not show a noticeable speed difference.
 
     /**
      * Creates a new instance for the given target document.



Mime
View raw message