pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1852175 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf: FDFAnnotationStamp.java FDFStampAnnotationAppearance.java
Date Fri, 25 Jan 2019 20:20:46 GMT
Author: tilman
Date: Fri Jan 25 20:20:46 2019
New Revision: 1852175

URL: http://svn.apache.org/viewvc?rev=1852175&view=rev
Log:
PDFBOX-4437: SonarQube fix

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationStamp.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFStampAnnotationAppearance.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationStamp.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationStamp.java?rev=1852175&r1=1852174&r2=1852175&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationStamp.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationStamp.java
Fri Jan 25 20:20:46 2019
@@ -117,7 +117,7 @@ public class FDFAnnotationStamp extends
             Element appearanceEl = stampAppearance.getDocumentElement();
 
             // Is the root node have tag as DICT, error otherwise
-            if (!appearanceEl.getNodeName().equalsIgnoreCase("dict"))
+            if (!"dict".equalsIgnoreCase(appearanceEl.getNodeName()))
             {
                 throw new IOException("Error while reading stamp document, "
                         + "root should be 'dict' and not '" + appearanceEl.getNodeName()
+ "'");

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFStampAnnotationAppearance.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFStampAnnotationAppearance.java?rev=1852175&r1=1852174&r2=1852175&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFStampAnnotationAppearance.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFStampAnnotationAppearance.java
Fri Jan 25 20:20:46 2019
@@ -66,12 +66,6 @@ class FDFStampAnnotationAppearance imple
         this.dictionary = dictionary;
     }
 
-    @Override
-    public COSDictionary getCOSObject()
-    {
-        return dictionary;
-    }
-
     /**
      * This will create an Appearance dictionary from an appearance XML document.
      *
@@ -122,6 +116,12 @@ class FDFStampAnnotationAppearance imple
         }
     }
 
+    @Override
+    public COSDictionary getCOSObject()
+    {
+        return dictionary;
+    }
+
     private COSStream parseStreamElement(Element streamEl) throws IOException
     {
         COSStream stream = new COSStream();



Mime
View raw message