From commits-return-13726-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Sun Dec 2 12:13:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8C395180609 for ; Sun, 2 Dec 2018 12:13:00 +0100 (CET) Received: (qmail 65999 invoked by uid 500); 2 Dec 2018 11:12:59 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 65987 invoked by uid 99); 2 Dec 2018 11:12:59 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Dec 2018 11:12:59 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 368343A00C7 for ; Sun, 2 Dec 2018 11:12:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1847970 - /pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java Date: Sun, 02 Dec 2018 11:12:59 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20181202111259.368343A00C7@svn01-us-west.apache.org> Author: tilman Date: Sun Dec 2 11:12:59 2018 New Revision: 1847970 URL: http://svn.apache.org/viewvc?rev=1847970&view=rev Log: PDFBOX-3017: SonarQube fix Modified: pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java Modified: pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java?rev=1847970&r1=1847969&r2=1847970&view=diff ============================================================================== --- pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java (original) +++ pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/OcspHelper.java Sun Dec 2 11:12:59 2018 @@ -251,7 +251,8 @@ public class OcspHelper catch (NoSuchAlgorithmException ex) { // should not happen - return null; + LOG.error("SHA-1 Algorithm not found", ex); + return new byte[0]; } } @@ -602,10 +603,11 @@ public class OcspHelper MessageDigest md = MessageDigest.getInstance("SHA-1"); return md.digest(bytes); } - catch (NoSuchAlgorithmException e) + catch (NoSuchAlgorithmException ex) { - LOG.error("SHA-1 Algorithm not found", e); - return null; + // should not happen + LOG.error("SHA-1 Algorithm not found", ex); + return new byte[0]; } } }