pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1843751 - /pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/CRLVerifier.java
Date Sat, 13 Oct 2018 13:20:24 GMT
Author: tilman
Date: Sat Oct 13 13:20:24 2018
New Revision: 1843751

URL: http://svn.apache.org/viewvc?rev=1843751&view=rev
Log:
PDFBOX-3017: simplify for loop, reformat

Modified:
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/CRLVerifier.java

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/CRLVerifier.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/CRLVerifier.java?rev=1843751&r1=1843750&r2=1843751&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/CRLVerifier.java
(original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/cert/CRLVerifier.java
Sat Oct 13 13:20:24 2018
@@ -188,22 +188,19 @@ public final class CRLVerifier
      * Point" extension in a X.509 certificate. If CRL distribution point
      * extension is unavailable, returns an empty list.
      */
-    public static List<String>
-            getCrlDistributionPoints(X509Certificate cert) throws CertificateParsingException,
IOException
+    public static List<String> getCrlDistributionPoints(X509Certificate cert)
+            throws CertificateParsingException, IOException
     {
-        byte[] crldpExt = cert
-                .getExtensionValue(Extension.cRLDistributionPoints.getId());
+        byte[] crldpExt = cert.getExtensionValue(Extension.cRLDistributionPoints.getId());
         if (crldpExt == null)
         {
             return new ArrayList<String>();
         }
-        ASN1InputStream oAsnInStream = new ASN1InputStream(
-                new ByteArrayInputStream(crldpExt));
+        ASN1InputStream oAsnInStream = new ASN1InputStream(new ByteArrayInputStream(crldpExt));
         ASN1Primitive derObjCrlDP = oAsnInStream.readObject();
         DEROctetString dosCrlDP = (DEROctetString) derObjCrlDP;
         byte[] crldpExtOctets = dosCrlDP.getOctets();
-        ASN1InputStream oAsnInStream2 = new ASN1InputStream(
-                new ByteArrayInputStream(crldpExtOctets));
+        ASN1InputStream oAsnInStream2 = new ASN1InputStream(new ByteArrayInputStream(crldpExtOctets));
         ASN1Primitive derObj2 = oAsnInStream2.readObject();
         CRLDistPoint distPoint = CRLDistPoint.getInstance(derObj2);
         List<String> crlUrls = new ArrayList<String>();
@@ -211,18 +208,14 @@ public final class CRLVerifier
         {
             DistributionPointName dpn = dp.getDistributionPoint();
             // Look for URIs in fullName
-            if (dpn != null
-                    && dpn.getType() == DistributionPointName.FULL_NAME)
+            if (dpn != null && dpn.getType() == DistributionPointName.FULL_NAME)
             {
-                GeneralName[] genNames = GeneralNames.getInstance(
-                        dpn.getName()).getNames();
                 // Look for an URI
-                for (int j = 0; j < genNames.length; j++)
+                for (GeneralName genName : GeneralNames.getInstance(dpn.getName()).getNames())
                 {
-                    if (genNames[j].getTagNo() == GeneralName.uniformResourceIdentifier)
+                    if (genName.getTagNo() == GeneralName.uniformResourceIdentifier)
                     {
-                        String url = DERIA5String.getInstance(
-                                genNames[j].getName()).getString();
+                        String url = DERIA5String.getInstance(genName.getName()).getString();
                         crlUrls.add(url);
                     }
                 }



Mime
View raw message