pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1840843 - /pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
Date Thu, 13 Sep 2018 17:14:33 GMT
Author: tilman
Date: Thu Sep 13 17:14:32 2018
New Revision: 1840843

URL: http://svn.apache.org/viewvc?rev=1840843&view=rev
Log:
PDFBOX-2941: restore logging window by removing LogFactory

Modified:
    pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java

Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java?rev=1840843&r1=1840842&r2=1840843&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java Thu Sep
13 17:14:32 2018
@@ -47,9 +47,6 @@ import java.util.Properties;
 import java.util.Set;
 import javax.imageio.spi.IIORegistry;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
 import javax.print.attribute.HashPrintRequestAttributeSet;
 import javax.print.attribute.PrintRequestAttributeSet;
 import javax.print.attribute.standard.Sides;
@@ -132,8 +129,6 @@ import org.apache.pdfbox.printing.PDFPag
  */
 public class PDFDebugger extends JFrame
 {
-    private static final Log LOG = LogFactory.getLog(PDFDebugger.class);
-
     private static final Set<COSName> SPECIALCOLORSPACES =
             new HashSet<>(Arrays.asList(COSName.INDEXED, COSName.SEPARATION, COSName.DEVICEN));
 
@@ -195,6 +190,7 @@ public class PDFDebugger extends JFrame
         initComponents();
 
         // use our custom logger
+        // this works only if there is no "LogFactory.getLog()" in this class!
         LogDialog.init(this, statusBar.getLogLabel());
         System.setProperty("org.apache.commons.logging.Log", "org.apache.pdfbox.debugger.ui.DebugLog");
     }
@@ -215,7 +211,8 @@ public class PDFDebugger extends JFrame
         }
         catch (ClassNotFoundException e)
         {
-            LOG.debug("KCMS service not found - using LCMS", e);
+            // jdk7 or lower (KCMS has different name),
+            // or jdk10 and higher (KCMS no longer available)
         }
 
         UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());



Mime
View raw message