pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1834180 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java
Date Sat, 23 Jun 2018 06:25:54 GMT
Author: tilman
Date: Sat Jun 23 06:25:54 2018
New Revision: 1834180

URL: http://svn.apache.org/viewvc?rev=1834180&view=rev
Log:
PDFBOX-3353: correct comments, add some thought for future refactoring

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java?rev=1834180&r1=1834179&r2=1834180&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDTextAppearanceHandler.java
Sat Jun 23 06:25:54 2018
@@ -423,6 +423,8 @@ public class PDTextAppearanceHandler ext
     }
 
     //TODO this is mostly identical to drawStar, except for scale, translation and symbol
+    // maybe use a table with all values and draw from there
+    // this could also optionally use outer circle
     private void drawCheck(PDAnnotationText annotation, final PDAppearanceContentStream contentStream)
             throws IOException
     {
@@ -483,7 +485,7 @@ public class PDTextAppearanceHandler ext
         contentStream.transform(Matrix.getScaleInstance(0.001f * min / 1.5f, 0.001f * min
/ 1.5f));
         contentStream.transform(Matrix.getTranslateInstance(0, 50));
 
-        // we get the shape of a Zapf Dingbats right pointer (0x27A4) and use that one.
+        // we get the shape of a Symbol crosshair (0x2295) and use that one.
         // Adobe uses a different font (which one?), or created the shape from scratch.
         GeneralPath path = PDType1Font.SYMBOL.getPath("circleplus");
         addPath(contentStream, path);
@@ -522,7 +524,7 @@ public class PDTextAppearanceHandler ext
         contentStream.transform(Matrix.getScaleInstance(0.001f * min / 1.3f, 0.001f * min
/ 1.3f));
         contentStream.transform(Matrix.getTranslateInstance(200, 300));
 
-        // we get the shape of a Zapf Dingbats right arrow and use that one.
+        // we get the shape of a Zapf Dingbats right arrow (0x2794) and use that one.
         // Adobe uses a different font (which one?), or created the shape from scratch.
         GeneralPath path = PDType1Font.ZAPF_DINGBATS.getPath("a160");
         addPath(contentStream, path);



Mime
View raw message