pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1832770 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDFreeTextAppearanceHandler.java
Date Sun, 03 Jun 2018 13:58:11 GMT
Author: tilman
Date: Sun Jun  3 13:58:11 2018
New Revision: 1832770

URL: http://svn.apache.org/viewvc?rev=1832770&view=rev
Log:
PDFBOX-3353: remove wrong comment; don't skip for width = 0, this is done by drawShape that
outputs an "n"

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDFreeTextAppearanceHandler.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDFreeTextAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDFreeTextAppearanceHandler.java?rev=1832770&r1=1832769&r2=1832770&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDFreeTextAppearanceHandler.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDFreeTextAppearanceHandler.java
Sun Jun  3 13:58:11 2018
@@ -71,19 +71,6 @@ public class PDFreeTextAppearanceHandler
         }
         AnnotationBorder ab = AnnotationBorder.getAnnotationBorder(annotation, annotation.getBorderStyle());
 
-        // width 0 = no border
-        // pdf_commenting_new.pdf page 3
-        // Root/Pages/Kids/[2]/Kids/[0]/Annots/[5]/BS/W
-        if (Float.compare(ab.width, 0) == 0)
-        {
-            //TODO what happens if there is a callout?
-            //TODO skip, don't return when we know how to make text
-            // (maybe refactor the rectangle drawing segment)
-            return;
-        }
-
-        //TODO how to set the text color? Apparently red is the default????
-
         try (PDAppearanceContentStream cs = getNormalAppearanceAsContentStream())
         {
             // The fill color is the /C entry, there is no /IC entry defined



Mime
View raw message