From commits-return-12625-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Thu May 31 20:07:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A13E0180632 for ; Thu, 31 May 2018 20:07:21 +0200 (CEST) Received: (qmail 53973 invoked by uid 500); 31 May 2018 18:07:20 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 53964 invoked by uid 99); 31 May 2018 18:07:20 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 May 2018 18:07:20 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 090393A00CB for ; Thu, 31 May 2018 18:07:19 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1832634 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Date: Thu, 31 May 2018 18:07:19 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20180531180720.090393A00CB@svn01-us-west.apache.org> Author: tilman Date: Thu May 31 18:07:19 2018 New Revision: 1832634 URL: http://svn.apache.org/viewvc?rev=1832634&view=rev Log: PDFBOX-4235: avoid NPE if font is not defined in /DA string Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java?rev=1832634&r1=1832633&r2=1832634&view=diff ============================================================================== --- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java (original) +++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Thu May 31 18:07:19 2018 @@ -411,6 +411,10 @@ class AppearanceGeneratorHelper // get the font PDFont font = defaultAppearance.getFont(); + if (font == null) + { + throw new IllegalStateException("font is null, check whether /DA entry is incomplete or incorrect"); + } // calculate the fontSize (because 0 = autosize) float fontSize = defaultAppearance.getFontSize();