pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1831885 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers: PDPolygonAppearanceHandler.java PDPolylineAppearanceHandler.java
Date Sat, 19 May 2018 12:26:33 GMT
Author: tilman
Date: Sat May 19 12:26:33 2018
New Revision: 1831885

URL: http://svn.apache.org/viewvc?rev=1831885&view=rev
Log:
PDFBOX-3353: move comment to correct class

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolygonAppearanceHandler.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolygonAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolygonAppearanceHandler.java?rev=1831885&r1=1831884&r2=1831885&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolygonAppearanceHandler.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolygonAppearanceHandler.java
Sat May 19 12:26:33 2018
@@ -157,19 +157,6 @@ public class PDPolygonAppearanceHandler
                         }
                     }
                 }
-
-                //TODO line endings (LE) are missing
-                // How it could be done by reusing some of the code from 
-                // the Line and StrikeOut handlers
-                // 1) if the LE is contained in SHORT_STYLES, 
-                // shorten the first + last arms with "this weird old trick"
-                // used in the StrikeOut handler
-                // and paint
-                // 2) do a transform so that first and last arms are imagined flat
-                // (like in Line handler)
-                // 3) refactor + reuse the line handler code that draws the ending shapes
-                // the alternative would be to apply the transform to the LE shapes directly,
-                // which would be more work and produce code difficult to understand
                 contentStream.drawShape(lineWidth, hasStroke, hasBackground);
             }
         }

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java?rev=1831885&r1=1831884&r2=1831885&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/handlers/PDPolylineAppearanceHandler.java
Sat May 19 12:26:33 2018
@@ -116,6 +116,18 @@ public class PDPolylineAppearanceHandler
                         cs.lineTo(x, y);
                     }
                 }
+                //TODO line endings (LE) are missing
+                // How it could be done by reusing some of the code from 
+                // the Line and StrikeOut handlers
+                // 1) if the LE is contained in SHORT_STYLES, 
+                // shorten the first + last arms with "this weird old trick"
+                // used in the StrikeOut handler
+                // and paint
+                // 2) do a transform so that first and last arms are imagined flat
+                // (like in Line handler)
+                // 3) refactor + reuse the line handler code that draws the ending shapes
+                // the alternative would be to apply the transform to the LE shapes directly,
+                // which would be more work and produce code difficult to understand
                 cs.stroke();
             }
         }



Mime
View raw message