From commits-return-11962-archive-asf-public=cust-asf.ponee.io@pdfbox.apache.org Wed Feb 21 18:07:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B058C18061A for ; Wed, 21 Feb 2018 18:07:21 +0100 (CET) Received: (qmail 68274 invoked by uid 500); 21 Feb 2018 17:07:20 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 68263 invoked by uid 99); 21 Feb 2018 17:07:20 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 17:07:20 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id C629A3A0115 for ; Wed, 21 Feb 2018 17:07:19 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1824989 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java Date: Wed, 21 Feb 2018 17:07:17 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20180221170719.C629A3A0115@svn01-us-west.apache.org> Author: tilman Date: Wed Feb 21 17:07:17 2018 New Revision: 1824989 URL: http://svn.apache.org/viewvc?rev=1824989&view=rev Log: PDFBOX-4071: make methods final that shouldn't be changed; make methods protected that shouldn't be accessed outside of class hierarchy Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java?rev=1824989&r1=1824988&r2=1824989&view=diff ============================================================================== --- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java (original) +++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDAction.java Wed Feb 21 17:07:17 2018 @@ -80,7 +80,7 @@ public abstract class PDAction implement * * @return The Type of PDF object. */ - public String getType() + public final String getType() { return action.getNameAsString( COSName.TYPE ); } @@ -91,7 +91,7 @@ public abstract class PDAction implement * * @param type The new Type for the PDF object. */ - public final void setType( String type ) + protected final void setType(String type) { action.setName(COSName.TYPE, type ); } @@ -101,7 +101,7 @@ public abstract class PDAction implement * * @return The S entry of actions dictionary. */ - public String getSubType() + public final String getSubType() { return action.getNameAsString(COSName.S); } @@ -111,7 +111,7 @@ public abstract class PDAction implement * * @param s The new type of action. */ - public void setSubType( String s ) + protected final void setSubType(String s) { action.setName(COSName.S, s); }