Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32BEE200D28 for ; Mon, 23 Oct 2017 22:28:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 317171609E0; Mon, 23 Oct 2017 20:28:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9EF8B1609DF for ; Mon, 23 Oct 2017 22:28:47 +0200 (CEST) Received: (qmail 23258 invoked by uid 500); 23 Oct 2017 20:28:46 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 23249 invoked by uid 99); 23 Oct 2017 20:28:46 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 20:28:46 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 0847D3A0251 for ; Mon, 23 Oct 2017 20:28:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1813087 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Date: Mon, 23 Oct 2017 20:28:46 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20171023202846.0847D3A0251@svn01-us-west.apache.org> archived-at: Mon, 23 Oct 2017 20:28:48 -0000 Author: tilman Date: Mon Oct 23 20:28:45 2017 New Revision: 1813087 URL: http://svn.apache.org/viewvc?rev=1813087&view=rev Log: PDFBOX-2852: instanceof doesn't need null check Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java?rev=1813087&r1=1813086&r2=1813087&view=diff ============================================================================== --- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java (original) +++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Mon Oct 23 20:28:45 2017 @@ -2148,7 +2148,7 @@ public class COSParser extends BaseParse { // check if all page objects are dereferenced COSBase pages = root.getDictionaryObject(COSName.PAGES); - if (pages != null && pages instanceof COSDictionary) + if (pages instanceof COSDictionary) { checkPagesDictionary((COSDictionary) pages); } @@ -2160,7 +2160,7 @@ public class COSParser extends BaseParse // check for kids COSBase kids = pagesDict.getDictionaryObject(COSName.KIDS); int numberOfPages = 0; - if (kids != null && kids instanceof COSArray) + if (kids instanceof COSArray) { COSArray kidsArray = (COSArray) kids; List kidsList = kidsArray.toList();