pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1797810 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible: PDFTemplateBuilder.java PDFTemplateCreator.java PDVisibleSigBuilder.java
Date Tue, 06 Jun 2017 16:51:37 GMT
Author: tilman
Date: Tue Jun  6 16:51:37 2017
New Revision: 1797810

URL: http://svn.apache.org/viewvc?rev=1797810&view=rev
Log:
PDFBOX-3817: clarify variable and parameter names

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateBuilder.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSigBuilder.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateBuilder.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateBuilder.java?rev=1797810&r1=1797809&r2=1797810&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateBuilder.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateBuilder.java
Tue Jun  6 16:51:37 2017
@@ -240,14 +240,14 @@ public interface PDFTemplateBuilder
      * @param holderFormStream
      * @param innerFormStream
      * @param imageFormStream
-     * @param imageObjectName
+     * @param imageFormName
      * @param imageName
      * @param innerFormName
      * @param properties
      * @throws IOException
      */
     void injectAppearanceStreams(PDStream holderFormStream, PDStream innerFormStream,
-            PDStream imageFormStream, COSName imageObjectName, COSName imageName,
+            PDStream imageFormStream, COSName imageFormName, COSName imageName,
             COSName innerFormName, PDVisibleSignDesigner properties) throws IOException;
 
     /**

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java?rev=1797810&r1=1797809&r2=1797810&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java
Tue Jun  6 16:51:37 2017
@@ -149,13 +149,13 @@ public class PDFTemplateCreator
         pdfBuilder.injectProcSetArray(innerForm, page, innerFormResource, imageFormResources,
                 holderFormResources, pdfStructure.getProcSet());
 
-        COSName imgFormName = pdfStructure.getImageFormName();
-        COSName imgName = pdfStructure.getImageName();
+        COSName imageFormName = pdfStructure.getImageFormName();
+        COSName imageName = pdfStructure.getImageName();
         COSName innerFormName = pdfStructure.getInnerFormName();
 
         // now create Streams of AP
         pdfBuilder.injectAppearanceStreams(holderFormStream, imageFormStream, imageFormStream,
-                imgFormName, imgName, innerFormName, properties);
+                imageFormName, imageName, innerFormName, properties);
         pdfBuilder.createVisualSignature(template);
         pdfBuilder.createWidgetDictionary(pdSignatureField, holderFormResources);
         

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSigBuilder.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSigBuilder.java?rev=1797810&r1=1797809&r2=1797810&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSigBuilder.java
(original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDVisibleSigBuilder.java
Tue Jun  6 16:51:37 2017
@@ -353,7 +353,7 @@ public class PDVisibleSigBuilder impleme
 
     @Override
     public void injectAppearanceStreams(PDStream holderFormStream, PDStream innerFormStream,
-                                        PDStream imageFormStream, COSName imageObjectName,
+                                        PDStream imageFormStream, COSName imageFormName,
                                         COSName imageName, COSName innerFormName,
                                         PDVisibleSignDesigner properties) throws IOException
     {
@@ -363,7 +363,7 @@ public class PDVisibleSigBuilder impleme
         // imageName + " Do Q\n" + builder.toString();
         String imgFormContent    = "q " + 100 + " 0 0 50 0 0 cm /" + imageName.getName()
+ " Do Q\n";
         String holderFormContent = "q 1 0 0 1 0 0 cm /" + innerFormName.getName() + " Do
Q\n";
-        String innerFormContent  = "q 1 0 0 1 0 0 cm /" + imageObjectName.getName() + " Do
Q\n";
+        String innerFormContent  = "q 1 0 0 1 0 0 cm /" + imageFormName.getName() + " Do
Q\n";
 
         appendRawCommands(pdfStructure.getHolderFormStream().createOutputStream(), holderFormContent);
         appendRawCommands(pdfStructure.getInnerFormStream().createOutputStream(), innerFormContent);



Mime
View raw message