Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AF9E6200C1F for ; Sat, 18 Feb 2017 14:55:36 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AE20B160B66; Sat, 18 Feb 2017 13:55:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 03AFE160B63 for ; Sat, 18 Feb 2017 14:55:35 +0100 (CET) Received: (qmail 62905 invoked by uid 500); 18 Feb 2017 13:55:34 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 62896 invoked by uid 99); 18 Feb 2017 13:55:34 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Feb 2017 13:55:34 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id A8DC83A090E for ; Sat, 18 Feb 2017 13:55:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1783550 - in /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading: PatchMeshesShadingContext.java Type5ShadingContext.java Date: Sat, 18 Feb 2017 13:55:33 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20170218135533.A8DC83A090E@svn01-us-west.apache.org> archived-at: Sat, 18 Feb 2017 13:55:36 -0000 Author: tilman Date: Sat Feb 18 13:55:33 2017 New Revision: 1783550 URL: http://svn.apache.org/viewvc?rev=1783550&view=rev Log: PDFBOX-2852: sonar fix: add an end condition to this loop Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PatchMeshesShadingContext.java pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/Type5ShadingContext.java Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PatchMeshesShadingContext.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PatchMeshesShadingContext.java?rev=1783550&r1=1783549&r2=1783550&view=diff ============================================================================== --- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PatchMeshesShadingContext.java (original) +++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PatchMeshesShadingContext.java Sat Feb 18 13:55:33 2017 @@ -114,7 +114,8 @@ abstract class PatchMeshesShadingContext LOG.error(ex); } - while (true) + boolean eof = false; + while (!eof) { try { @@ -150,7 +151,7 @@ abstract class PatchMeshesShadingContext } catch (EOFException ex) { - break; + eof = true; } } } Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/Type5ShadingContext.java URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/Type5ShadingContext.java?rev=1783550&r1=1783549&r2=1783550&view=diff ============================================================================== --- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/Type5ShadingContext.java (original) +++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/Type5ShadingContext.java Sat Feb 18 13:55:33 2017 @@ -83,7 +83,8 @@ class Type5ShadingContext extends Gourau ImageInputStream mciis = new MemoryCacheImageInputStream(cosStream.createInputStream()); try { - while (true) + boolean eof = false; + while (!eof) { Vertex p; try @@ -93,7 +94,7 @@ class Type5ShadingContext extends Gourau } catch (EOFException ex) { - break; + eof = true; } } }