pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1745796 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/SmallMap.java
Date Fri, 27 May 2016 17:54:34 GMT
Author: tilman
Date: Fri May 27 17:54:34 2016
New Revision: 1745796

URL: http://svn.apache.org/viewvc?rev=1745796&view=rev
Log:
PDFBOX-2852: make methods final that are called during construction; remove unneeded modifiers

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/SmallMap.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/SmallMap.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/SmallMap.java?rev=1745796&r1=1745795&r2=1745796&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/SmallMap.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/util/SmallMap.java Fri May 27 17:54:34
2016
@@ -55,7 +55,7 @@ public class SmallMap<K, V> implements M
      * Returns index of key within map-array or <code>-1</code>
      * if key is not found (or key is <code>null</code>).
      */
-    private final int findKey(Object key)
+    private int findKey(Object key)
     {
         if (isEmpty() || (key==null))
         {
@@ -77,7 +77,7 @@ public class SmallMap<K, V> implements M
      * Returns index of value within map-array or <code>-1</code>
      * if value is not found (or value is <code>null</code>).
      */
-    private final int findValue(Object value)
+    private int findValue(Object value)
     {
         if (isEmpty() || (value==null))
         {
@@ -199,7 +199,7 @@ public class SmallMap<K, V> implements M
     }
 
     @Override
-    public void putAll(Map<? extends K, ? extends V> otherMap)
+    public final void putAll(Map<? extends K, ? extends V> otherMap)
     {
         if ((mapArr == null) || (mapArr.length == 0))
         {
@@ -317,7 +317,7 @@ public class SmallMap<K, V> implements M
     {
         private final int keyIdx;
         
-        public SmallMapEntry(int keyInMapIdx)
+        SmallMapEntry(int keyInMapIdx)
         {
             keyIdx = keyInMapIdx;
         }



Mime
View raw message