Return-Path: X-Original-To: apmail-pdfbox-commits-archive@www.apache.org Delivered-To: apmail-pdfbox-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65D7418AF7 for ; Sun, 10 Jan 2016 13:55:29 +0000 (UTC) Received: (qmail 77084 invoked by uid 500); 10 Jan 2016 13:55:28 -0000 Delivered-To: apmail-pdfbox-commits-archive@pdfbox.apache.org Received: (qmail 77056 invoked by uid 500); 10 Jan 2016 13:55:28 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 77045 invoked by uid 99); 10 Jan 2016 13:55:28 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2016 13:55:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 762A9C2A04 for ; Sun, 10 Jan 2016 13:55:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.999 X-Spam-Level: X-Spam-Status: No, score=0.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GyHhsygWjyiI for ; Sun, 10 Jan 2016 13:55:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTP id 3184B2114D for ; Sun, 10 Jan 2016 13:55:27 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3902AE0678 for ; Sun, 10 Jan 2016 13:55:26 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id F19583A0249 for ; Sun, 10 Jan 2016 13:55:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1723927 - /pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/ImportFDF.java Date: Sun, 10 Jan 2016 13:55:25 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160110135525.F19583A0249@svn01-us-west.apache.org> Author: tilman Date: Sun Jan 10 13:55:25 2016 New Revision: 1723927 URL: http://svn.apache.org/viewvc?rev=1723927&view=rev Log: PDFBOX-962: avoid NPE; setNeedAppearances Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/ImportFDF.java Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/ImportFDF.java URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/ImportFDF.java?rev=1723927&r1=1723926&r2=1723927&view=diff ============================================================================== --- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/ImportFDF.java (original) +++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/ImportFDF.java Sun Jan 10 13:55:25 2016 @@ -18,6 +18,9 @@ package org.apache.pdfbox; import java.io.IOException; +import org.apache.pdfbox.cos.COSDictionary; +import org.apache.pdfbox.cos.COSName; + import org.apache.pdfbox.pdmodel.PDDocument; import org.apache.pdfbox.pdmodel.PDDocumentCatalog; @@ -54,8 +57,15 @@ public class ImportFDF { PDDocumentCatalog docCatalog = pdfDocument.getDocumentCatalog(); PDAcroForm acroForm = docCatalog.getAcroForm(); - acroForm.setCacheFields( true ); + if (acroForm == null) + { + return; + } + acroForm.setCacheFields(true); acroForm.importFDF( fdfDocument ); + + //TODO this can be removed when we create appearance streams + ((COSDictionary) acroForm.getCOSObject()).setBoolean(COSName.getPDFName("NeedAppearances"), true); } /**