pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1688746 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java
Date Wed, 01 Jul 2015 22:14:30 GMT
Author: tilman
Date: Wed Jul  1 22:14:30 2015
New Revision: 1688746

URL: http://svn.apache.org/r1688746
Log:
PDFBOX-2576: avoid overridable method call during object construction

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java?rev=1688746&r1=1688745&r2=1688746&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java Wed
Jul  1 22:14:30 2015
@@ -137,7 +137,7 @@ public class PDType1CFont extends PDSimp
     /**
      * Returns the PostScript name of the font.
      */
-    public String getBaseFont()
+    public final String getBaseFont()
     {
         return dict.getNameAsString(COSName.BASE_FONT);
     }
@@ -163,7 +163,7 @@ public class PDType1CFont extends PDSimp
     }
 
     @Override
-    public String getName()
+    public final String getName()
     {
         return getBaseFont();
     }
@@ -193,6 +193,7 @@ public class PDType1CFont extends PDSimp
             // extract from Type1 font/substitute
             if (genericFont instanceof EncodedFont)
             {
+                //FIXME dead instanceof
                 return Type1Encoding.fromFontBox(((EncodedFont) genericFont).getEncoding());
             }
             else
@@ -210,7 +211,7 @@ public class PDType1CFont extends PDSimp
     }
 
     @Override
-    public Matrix getFontMatrix()
+    public final Matrix getFontMatrix()
     {
         if (fontMatrix == null)
         {



Mime
View raw message