Return-Path: X-Original-To: apmail-pdfbox-commits-archive@www.apache.org Delivered-To: apmail-pdfbox-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9949117283 for ; Thu, 2 Apr 2015 21:06:03 +0000 (UTC) Received: (qmail 20477 invoked by uid 500); 2 Apr 2015 21:06:00 -0000 Delivered-To: apmail-pdfbox-commits-archive@pdfbox.apache.org Received: (qmail 20455 invoked by uid 500); 2 Apr 2015 21:06:00 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 20446 invoked by uid 99); 2 Apr 2015 21:06:00 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2015 21:06:00 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 4F0EBAC012B for ; Thu, 2 Apr 2015 21:06:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1670968 - in /pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox: pdfparser/PDFXrefStreamParser.java pdfwriter/ContentStreamWriter.java Date: Thu, 02 Apr 2015 21:06:00 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20150402210600.4F0EBAC012B@hades.apache.org> Author: tilman Date: Thu Apr 2 21:05:59 2015 New Revision: 1670968 URL: http://svn.apache.org/r1670968 Log: PDFBOX-2576: make fields final; remove boxing / unboxing Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFXrefStreamParser.java pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFXrefStreamParser.java URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFXrefStreamParser.java?rev=1670968&r1=1670967&r2=1670968&view=diff ============================================================================== --- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFXrefStreamParser.java (original) +++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/PDFXrefStreamParser.java Thu Apr 2 21:05:59 2015 @@ -38,8 +38,8 @@ import org.apache.pdfbox.persistence.uti */ public class PDFXrefStreamParser extends BaseParser { - private COSStream stream; - private XrefTrailerResolver xrefTrailerResolver; + private final COSStream stream; + private final XrefTrailerResolver xrefTrailerResolver; /** * Constructor. @@ -96,7 +96,7 @@ public class PDFXrefStreamParser extends int size = ((COSInteger)indexIter.next()).intValue(); for(int i = 0; i < size; i++) { - objNums.add(new Integer(objID + i)); + objNums.add(objID + i); } } Iterator objIter = objNums.iterator(); @@ -145,7 +145,7 @@ public class PDFXrefStreamParser extends { genNum += (currLine[i + w0 + w1] & 0x00ff) << ((w2 - i - 1) * 8); } - COSObjectKey objKey = new COSObjectKey(objID.intValue(), genNum); + COSObjectKey objKey = new COSObjectKey(objID, genNum); xrefTrailerResolver.setXRef(objKey, offset); break; case 2: @@ -168,7 +168,7 @@ public class PDFXrefStreamParser extends { objstmObjNr += (currLine[i + w0] & 0x00ff) << ((w1 - i - 1) * 8); } - objKey = new COSObjectKey( objID.intValue(), 0 ); + objKey = new COSObjectKey(objID, 0); xrefTrailerResolver.setXRef( objKey, -objstmObjNr ); break; default: Modified: pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java?rev=1670968&r1=1670967&r2=1670968&view=diff ============================================================================== --- pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java (original) +++ pdfbox/branches/1.8/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java Thu Apr 2 21:05:59 2015 @@ -19,7 +19,6 @@ package org.apache.pdfbox.pdfwriter; import java.io.IOException; import java.io.OutputStream; -import java.util.Iterator; import java.util.List; import java.util.Map; @@ -43,7 +42,7 @@ import org.apache.pdfbox.util.PDFOperato */ public class ContentStreamWriter { - private OutputStream output; + private final OutputStream output; /** * space character. */