Return-Path: X-Original-To: apmail-pdfbox-commits-archive@www.apache.org Delivered-To: apmail-pdfbox-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95F95173A1 for ; Wed, 1 Apr 2015 19:50:45 +0000 (UTC) Received: (qmail 65040 invoked by uid 500); 1 Apr 2015 19:50:45 -0000 Delivered-To: apmail-pdfbox-commits-archive@pdfbox.apache.org Received: (qmail 65015 invoked by uid 500); 1 Apr 2015 19:50:45 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 65005 invoked by uid 99); 1 Apr 2015 19:50:45 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2015 19:50:45 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 552A7AC006A for ; Wed, 1 Apr 2015 19:50:45 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1670763 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java Date: Wed, 01 Apr 2015 19:50:45 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20150401195045.552A7AC006A@hades.apache.org> Author: tilman Date: Wed Apr 1 19:50:44 2015 New Revision: 1670763 URL: http://svn.apache.org/r1670763 Log: PDFBOX-2576: remove unneeded cast; make fields final Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java?rev=1670763&r1=1670762&r2=1670763&view=diff ============================================================================== --- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java (original) +++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentProperties.java Wed Apr 1 19:50:44 2015 @@ -46,7 +46,7 @@ public class PDOptionalContentProperties /** The "Unchanged" value. */ UNCHANGED(COSName.UNCHANGED); - private COSName name; + private final COSName name; private BaseState(COSName value) { @@ -78,7 +78,7 @@ public class PDOptionalContentProperties } - private COSDictionary dict; + private final COSDictionary dict; /** * Creates a new optional content properties dictionary. @@ -100,6 +100,7 @@ public class PDOptionalContentProperties } /** {@inheritDoc} */ + @Override public COSBase getCOSObject() { return this.dict; @@ -214,7 +215,7 @@ public class PDOptionalContentProperties String[] groups = new String[size]; for (int i = 0; i < size; i++) { - COSBase obj = (COSBase)ocgs.get(i); + COSBase obj = ocgs.get(i); COSDictionary ocg = toDictionary(obj); groups[i] = ocg.getString(COSName.NAME); }