Return-Path: X-Original-To: apmail-pdfbox-commits-archive@www.apache.org Delivered-To: apmail-pdfbox-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 485321743B for ; Fri, 23 Jan 2015 22:59:49 +0000 (UTC) Received: (qmail 72567 invoked by uid 500); 23 Jan 2015 22:59:49 -0000 Delivered-To: apmail-pdfbox-commits-archive@pdfbox.apache.org Received: (qmail 72543 invoked by uid 500); 23 Jan 2015 22:59:49 -0000 Mailing-List: contact commits-help@pdfbox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pdfbox.apache.org Delivered-To: mailing list commits@pdfbox.apache.org Received: (qmail 72533 invoked by uid 99); 23 Jan 2015 22:59:49 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 22:59:49 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 14576AC0044; Fri, 23 Jan 2015 22:59:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1654429 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java Date: Fri, 23 Jan 2015 22:59:48 -0000 To: commits@pdfbox.apache.org From: tilman@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20150123225949.14576AC0044@hades.apache.org> Author: tilman Date: Fri Jan 23 22:59:48 2015 New Revision: 1654429 URL: http://svn.apache.org/r1654429 Log: PDFBOX-2576: set field final; loop must have braces Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java?rev=1654429&r1=1654428&r2=1654429&view=diff ============================================================================== --- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java (original) +++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java Fri Jan 23 22:59:48 2015 @@ -41,7 +41,7 @@ import org.apache.pdfbox.cos.COSString; public class PDNameTreeNode implements COSObjectable { private static final Log LOG = LogFactory.getLog(PDNameTreeNode.class); - private COSDictionary node; + private final COSDictionary node; private Class valueType = null; private PDNameTreeNode parent = null; @@ -152,7 +152,9 @@ public class PDNameTreeNode implements C if (kids != null && kids.size() > 0) { for (PDNameTreeNode kidsNode : kids) + { kidsNode.setParent(this); + } node.setItem( COSName.KIDS, COSArrayList.converterToCOSArray( kids ) ); // root nodes with kids don't have Names if (isRootNode())