pdfbox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From til...@apache.org
Subject svn commit: r1652232 - /pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/schema/XMPSchemaFactory.java
Date Thu, 15 Jan 2015 19:07:41 GMT
Author: tilman
Date: Thu Jan 15 19:07:41 2015
New Revision: 1652232

URL: http://svn.apache.org/r1652232
Log:
PDFBOX-2576: make fields final

Modified:
    pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/schema/XMPSchemaFactory.java

Modified: pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/schema/XMPSchemaFactory.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/schema/XMPSchemaFactory.java?rev=1652232&r1=1652231&r2=1652232&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/schema/XMPSchemaFactory.java (original)
+++ pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/schema/XMPSchemaFactory.java Thu Jan
15 19:07:41 2015
@@ -36,11 +36,11 @@ import org.apache.xmpbox.type.PropertyTy
 public class XMPSchemaFactory
 {
 
-    private String namespace;
+    private final String namespace;
 
-    private Class<? extends XMPSchema> schemaClass;
+    private final Class<? extends XMPSchema> schemaClass;
 
-    private PropertiesDescription propDef;
+    private final PropertiesDescription propDef;
 
     private String nsName;
 
@@ -96,7 +96,7 @@ public class XMPSchemaFactory
      */
     public XMPSchema createXMPSchema(XMPMetadata metadata, String prefix) throws XmpSchemaException
     {
-        XMPSchema schema = null;
+        XMPSchema schema;
         Class<?>[] argsClass;
         Object[] schemaArgs;
 
@@ -129,7 +129,7 @@ public class XMPSchemaFactory
         }
         catch (Exception e)
         {
-            throw new XmpSchemaException("Cannot Instanciate specified Object Schema", e);
+            throw new XmpSchemaException("Cannot instanciate specified object schema", e);
         }
     }
 



Mime
View raw message