parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fo...@apache.org
Subject [parquet-mr] branch master updated: PARQUET-1499: Add Java 11 to Travis (#596)
Date Fri, 25 Oct 2019 23:06:07 GMT
This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new 19b10ac  PARQUET-1499: Add Java 11 to Travis (#596)
19b10ac is described below

commit 19b10acaba799098f374b32f405cd63ea7076f51
Author: Fokko Driesprong <fokko@apache.org>
AuthorDate: Sat Oct 26 01:05:58 2019 +0200

    PARQUET-1499: Add Java 11 to Travis (#596)
    
    Got some weird warnings from generated code:
    
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.9.1:javadoc
(default-cli) on project parquet-format-structures: An error has occurred in JavaDocs report
generation:
    [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the
packages defined in http://docs.oracle.com/javase/7/docs/api/ are in the unnamed module.
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:394:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:407:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:84:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:150:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:159:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:29:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49:
warning - invalid usage of tag <
    [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21:
warning - invalid usage of tag <
---
 .travis.yml                                               |  5 ++++-
 dev/travis-before_install.sh                              |  6 +++---
 parquet-format-structures/pom.xml                         | 10 +++++++---
 .../java/org/apache/parquet/hadoop/codec/CleanUtil.java   |  1 -
 pom.xml                                                   | 15 ++++++++++++++-
 5 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index fae25f8..77b16d9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,8 +1,11 @@
 language: java
-jdk: openjdk8
 before_install:
   - bash dev/travis-before_install.sh
 
+jdk:
+  - openjdk8
+  - openjdk11
+
 env:
   - HADOOP_PROFILE=default TEST_CODECS=uncompressed,brotli
   - HADOOP_PROFILE=default TEST_CODECS=gzip,snappy
diff --git a/dev/travis-before_install.sh b/dev/travis-before_install.sh
old mode 100644
new mode 100755
index 3575706..14b8ca2
--- a/dev/travis-before_install.sh
+++ b/dev/travis-before_install.sh
@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # Licensed to the Apache Software Foundation (ASF) under one
 # or more contributor license agreements.  See the NOTICE file
 # distributed with this work for additional information
@@ -24,13 +25,12 @@ export THIFT_VERSION=0.12.0
 set -e
 date
 sudo apt-get update -qq
-sudo apt-get install -qq build-essential pv autoconf automake libtool curl make \
+sudo apt-get install -qq --no-install-recommends build-essential pv autoconf automake libtool
curl make \
    g++ unzip libboost-dev libboost-test-dev libboost-program-options-dev \
    libevent-dev automake libtool flex bison pkg-config g++ libssl-dev xmlstarlet
 date
 pwd
-wget -nv https://archive.apache.org/dist/thrift/${THIFT_VERSION}/thrift-${THIFT_VERSION}.tar.gz
-tar zxf thrift-${THIFT_VERSION}.tar.gz
+wget -qO- https://archive.apache.org/dist/thrift/0.12.0/thrift-0.12.0.tar.gz | tar zxf -
 cd thrift-${THIFT_VERSION}
 chmod +x ./configure
 ./configure --disable-libs
diff --git a/parquet-format-structures/pom.xml b/parquet-format-structures/pom.xml
index a5dbabb..0ccf2ae 100644
--- a/parquet-format-structures/pom.xml
+++ b/parquet-format-structures/pom.xml
@@ -70,7 +70,7 @@
       <plugin>
         <groupId>org.apache.thrift</groupId>
         <artifactId>thrift-maven-plugin</artifactId>
-        <version>${thrift-maven-plugin.version}</version>        
+        <version>${thrift-maven-plugin.version}</version>
         <configuration>
           <thriftSourceRoot>${parquet.thrift.path}</thriftSourceRoot>
           <thriftExecutable>${format.thrift.executable}</thriftExecutable>
@@ -126,9 +126,11 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
+        <version>${maven-javadoc-plugin.version}</version>
         <configuration>
           <!-- We have to turn off the javadoc check because thrift generates improper
comments -->
-          <additionalparam>-Xdoclint:none</additionalparam>
+          <doclint>none</doclint>
+          <source>8</source>
         </configuration>
       </plugin>
     </plugins>
@@ -139,9 +141,11 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
+        <version>${maven-javadoc-plugin.version}</version>
         <configuration>
           <!-- We have to turn off the javadoc check because thrift generates improper
comments -->
-          <additionalparam>-Xdoclint:none</additionalparam>
+          <doclint>none</doclint>
+          <source>8</source>
         </configuration>
       </plugin>
     </plugins>
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/CleanUtil.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/CleanUtil.java
index 82b1414..fed2999 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/CleanUtil.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/codec/CleanUtil.java
@@ -108,5 +108,4 @@ public class CleanUtil
       }
     }
   }
-
 }
diff --git a/pom.xml b/pom.xml
index b12dad0..5cf52d0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -103,6 +103,7 @@
     <guava.version>27.0.1-jre</guava.version>
     <brotli-codec.version>0.1.1</brotli-codec.version>
     <mockito.version>1.10.19</mockito.version>
+    <maven-javadoc-plugin.version>3.1.0</maven-javadoc-plugin.version>
 
     <!-- parquet-cli dependencies -->
     <opencsv.version>2.3</opencsv.version>
@@ -163,7 +164,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
-        <version>2.9</version>
+        <version>${maven-javadoc-plugin.version}</version>
         <reportSets>
           <reportSet><!-- by default, id = "default" -->
             <reports><!-- select non-aggregate reports -->
@@ -183,6 +184,7 @@
           <sourceFileExcludes>
             <sourceFileExclude>**/generated-sources/**/*.java</sourceFileExclude>
           </sourceFileExcludes>
+          <source>8</source>
         </configuration>
       </plugin>
       <plugin>
@@ -366,6 +368,17 @@
     </pluginManagement>
     <plugins>
       <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-javadoc-plugin</artifactId>
+        <version>${maven-javadoc-plugin.version}</version>
+        <configuration>
+          <sourceFileExcludes>
+            <sourceFileExclude>**/generated-sources/**/*.java</sourceFileExclude>
+          </sourceFileExcludes>
+          <source>8</source>
+        </configuration>
+      </plugin>
+      <plugin>
         <groupId>com.mycila.maven-license-plugin</groupId>
         <artifactId>maven-license-plugin</artifactId>
         <version>1.10.b1</version>


Mime
View raw message