parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ziva...@apache.org
Subject [parquet-mr] branch master updated: PARQUET-1460: Fix javadoc errors and include javadoc checking in Travis checks (#554)
Date Wed, 21 Nov 2018 16:12:05 GMT
This is an automated email from the ASF dual-hosted git repository.

zivanfi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-mr.git


The following commit(s) were added to refs/heads/master by this push:
     new a7b5a4b  PARQUET-1460: Fix javadoc errors and include javadoc checking in Travis
checks (#554)
a7b5a4b is described below

commit a7b5a4b24a3e17edce9273a0654e799075c86dbe
Author: Gabor Szadovszky <gabor@apache.org>
AuthorDate: Wed Nov 21 17:12:00 2018 +0100

    PARQUET-1460: Fix javadoc errors and include javadoc checking in Travis checks (#554)
---
 .travis.yml                                                           | 2 +-
 .../main/java/org/apache/parquet/benchmarks/FilteringBenchmarks.java  | 2 +-
 .../src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java    | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 7ab4846..e4e623f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -35,4 +35,4 @@ env:
   - HADOOP_PROFILE=default TEST_CODECS=gzip,snappy
 
 install: mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dsource.skip=true
| pv -fbi 60 > mvn_install.log || (cat mvn_install.log && false)
-script: mvn verify -P $HADOOP_PROFILE
+script: mvn verify javadoc:javadoc -P $HADOOP_PROFILE
diff --git a/parquet-benchmarks/src/main/java/org/apache/parquet/benchmarks/FilteringBenchmarks.java
b/parquet-benchmarks/src/main/java/org/apache/parquet/benchmarks/FilteringBenchmarks.java
index eb95c8d..ac47f7b 100644
--- a/parquet-benchmarks/src/main/java/org/apache/parquet/benchmarks/FilteringBenchmarks.java
+++ b/parquet-benchmarks/src/main/java/org/apache/parquet/benchmarks/FilteringBenchmarks.java
@@ -79,7 +79,7 @@ import it.unimi.dsi.fastutil.longs.LongList;
  * <a href="https://jmh.morethan.io">https://jmh.morethan.io</a>.
  *
  * <pre>
- * mvn clean package && java -jar target/parquet-benchmarks.jar org.apache.parquet.benchmarks.FilteringBenchmarks
-rf json
+ * mvn clean package &amp;&amp; java -jar target/parquet-benchmarks.jar org.apache.parquet.benchmarks.FilteringBenchmarks
-rf json
  * </pre>
  */
 @BenchmarkMode(SingleShotTime)
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
index 5352309..01867c6 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
@@ -864,12 +864,12 @@ public class ParquetFileReader implements Closeable {
   /**
    * Reads all the columns requested from the row group at the current file position. It
may skip specific pages based
    * on the column indexes according to the actual filter. As the rows are not aligned among
the pages of the different
-   * columns row synchronization might be required.
+   * columns row synchronization might be required. See the documentation of the class SynchronizingColumnReader
for
+   * details.
    *
    * @return the PageReadStore which can provide PageReaders for each column
    * @throws IOException
    *           if any I/O error occurs while reading
-   * @see {@link PageReadStore#isInPageFilteringMode()}
    */
   public PageReadStore readNextFilteredRowGroup() throws IOException {
     if (currentBlock == blocks.size()) {


Mime
View raw message