parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject [parquet-cpp] branch master updated: PARQUET-1323: Fix compiler warnings on clang-6
Date Tue, 24 Jul 2018 01:14:43 GMT
This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new 5264ad4  PARQUET-1323: Fix compiler warnings on clang-6
5264ad4 is described below

commit 5264ad405a1be2939cd67902f43c626cdf6e8d07
Author: Wes McKinney <wes.mckinney@twosigma.com>
AuthorDate: Mon Jul 23 21:14:39 2018 -0400

    PARQUET-1323: Fix compiler warnings on clang-6
    
    The `schema_descr_` field was unused
    
    Author: Wes McKinney <wes.mckinney@twosigma.com>
    
    Closes #478 from wesm/clang-6-warnings and squashes the following commits:
    
    7cadfab [Wes McKinney] Fix compiler warnings on clang-6
---
 src/parquet/arrow/reader.cc | 2 +-
 src/parquet/metadata.cc     | 2 +-
 src/parquet/schema.cc       | 3 +--
 src/parquet/schema.h        | 5 -----
 4 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/parquet/arrow/reader.cc b/src/parquet/arrow/reader.cc
index be270a8..0f671b7 100644
--- a/src/parquet/arrow/reader.cc
+++ b/src/parquet/arrow/reader.cc
@@ -165,7 +165,7 @@ class RowGroupRecordBatchReader : public ::arrow::RecordBatchReader {
         file_reader_(reader),
         next_row_group_(0) {}
 
-  ~RowGroupRecordBatchReader() {}
+  ~RowGroupRecordBatchReader() override {}
 
   std::shared_ptr<::arrow::Schema> schema() const override { return schema_; }
 
diff --git a/src/parquet/metadata.cc b/src/parquet/metadata.cc
index ee91b39..49999a4 100644
--- a/src/parquet/metadata.cc
+++ b/src/parquet/metadata.cc
@@ -66,7 +66,7 @@ static std::shared_ptr<RowGroupStatistics> MakeTypedColumnStats(
 
 std::shared_ptr<RowGroupStatistics> MakeColumnStats(
     const format::ColumnMetaData& meta_data, const ColumnDescriptor* descr) {
-  switch (meta_data.type) {
+  switch (static_cast<Type::type>(meta_data.type)) {
     case Type::BOOLEAN:
       return MakeTypedColumnStats<BooleanType>(meta_data, descr);
     case Type::INT32:
diff --git a/src/parquet/schema.cc b/src/parquet/schema.cc
index 5c3958e..7718781 100644
--- a/src/parquet/schema.cc
+++ b/src/parquet/schema.cc
@@ -690,8 +690,7 @@ ColumnDescriptor::ColumnDescriptor(const schema::NodePtr& node,
                                    const SchemaDescriptor* schema_descr)
     : node_(node),
       max_definition_level_(max_definition_level),
-      max_repetition_level_(max_repetition_level),
-      schema_descr_(schema_descr) {
+      max_repetition_level_(max_repetition_level) {
   if (!node_->is_primitive()) {
     throw ParquetException("Must be a primitive type");
   }
diff --git a/src/parquet/schema.h b/src/parquet/schema.h
index b778e51..1a94ed1 100644
--- a/src/parquet/schema.h
+++ b/src/parquet/schema.h
@@ -369,11 +369,6 @@ class PARQUET_EXPORT ColumnDescriptor {
 
   int16_t max_definition_level_;
   int16_t max_repetition_level_;
-
-  // When this descriptor is part of a real schema (and not being used for
-  // testing purposes), maintain a link back to the parent SchemaDescriptor to
-  // enable reverse graph traversals
-  const SchemaDescriptor* schema_descr_;
 };
 
 // Container for the converted Parquet schema with a computed information from


Mime
View raw message