parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject parquet-cpp git commit: PARQUET-1042: Fix Compilation breaks on GCC 4.8
Date Fri, 23 Jun 2017 15:14:09 GMT
Repository: parquet-cpp
Updated Branches:
  refs/heads/master 9adbe6d2a -> 05b00fa7e


PARQUET-1042: Fix Compilation breaks on GCC 4.8

Not the most beautiful, but verified locally in docker.

Author: Uwe L. Korn <uwe@apache.org>

Closes #359 from xhochy/fix-private and squashes the following commits:

9c2045e [Uwe L. Korn] PARQUET-1042: Fix Compilation breaks on GCC 4.8


Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/05b00fa7
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/05b00fa7
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/05b00fa7

Branch: refs/heads/master
Commit: 05b00fa7e8c662cddfcb9572c2433c8c8be828a5
Parents: 9adbe6d
Author: Uwe L. Korn <uwe@apache.org>
Authored: Fri Jun 23 11:14:04 2017 -0400
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Fri Jun 23 11:14:04 2017 -0400

----------------------------------------------------------------------
 src/parquet/arrow/reader.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/05b00fa7/src/parquet/arrow/reader.h
----------------------------------------------------------------------
diff --git a/src/parquet/arrow/reader.h b/src/parquet/arrow/reader.h
index 3a97c83..06a64f8 100644
--- a/src/parquet/arrow/reader.h
+++ b/src/parquet/arrow/reader.h
@@ -169,6 +169,7 @@ class PARQUET_EXPORT FileReader {
 // might change in the future.
 class PARQUET_EXPORT ColumnReader {
  public:
+  class PARQUET_NO_EXPORT Impl;
   virtual ~ColumnReader();
 
   // Scan the next array of the indicated size. The actual size of the
@@ -183,7 +184,6 @@ class PARQUET_EXPORT ColumnReader {
   ::arrow::Status NextBatch(int batch_size, std::shared_ptr<::arrow::Array>* out);
 
  private:
-  class PARQUET_NO_EXPORT Impl;
   std::unique_ptr<Impl> impl_;
   explicit ColumnReader(std::unique_ptr<Impl> impl);
 


Mime
View raw message