parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject parquet-cpp git commit: PARQUET-935: Set version to shared library
Date Sat, 01 Apr 2017 04:04:19 GMT
Repository: parquet-cpp
Updated Branches:
  refs/heads/master c2e440df1 -> 3cf1eb249


PARQUET-935: Set version to shared library

.deb package builder assumes that shared libraries have version.
See also: https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

Author: Kouhei Sutou <kou@clear-code.com>

Closes #282 from kou/set-version-to-shared-library and squashes the following commits:

b6bbeb9 [Kouhei Sutou] Set version to shared library


Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/3cf1eb24
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/3cf1eb24
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/3cf1eb24

Branch: refs/heads/master
Commit: 3cf1eb2496cfd76960b3a861d54c97a98bc64c5d
Parents: c2e440d
Author: Kouhei Sutou <kou@clear-code.com>
Authored: Sat Apr 1 00:04:13 2017 -0400
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Sat Apr 1 00:04:13 2017 -0400

----------------------------------------------------------------------
 CMakeLists.txt                   | 7 ++++++-
 src/parquet/arrow/CMakeLists.txt | 4 +++-
 2 files changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/3cf1eb24/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 00bb93c..11b8d5d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -31,6 +31,9 @@ else()
   include(GNUInstallDirs)
 endif()
 
+set(PARQUET_SO_VERSION "1")
+set(PARQUET_ABI_VERSION "${PARQUET_SO_VERSION}.0.0")
+
 if (NOT "$ENV{PARQUET_GCC_ROOT}" STREQUAL "")
   set(GCC_ROOT $ENV{PARQUET_GCC_ROOT})
   set(CMAKE_C_COMPILER ${GCC_ROOT}/bin/gcc)
@@ -613,7 +616,9 @@ if (PARQUET_BUILD_SHARED)
       PROPERTIES
       LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}"
       LINK_FLAGS "${SHARED_LINK_FLAGS}"
-      OUTPUT_NAME "parquet")
+      OUTPUT_NAME "parquet"
+      VERSION "${PARQUET_ABI_VERSION}"
+      SOVERSION "${PARQUET_SO_VERSION}")
     target_link_libraries(parquet_shared
       LINK_PRIVATE ${LIBPARQUET_INTERFACE_LINK_LIBS})
     if (PARQUET_RPATH_ORIGIN)

http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/3cf1eb24/src/parquet/arrow/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/src/parquet/arrow/CMakeLists.txt b/src/parquet/arrow/CMakeLists.txt
index 76bc5b9..8bc6af7 100644
--- a/src/parquet/arrow/CMakeLists.txt
+++ b/src/parquet/arrow/CMakeLists.txt
@@ -42,7 +42,9 @@ if (PARQUET_BUILD_SHARED)
       PROPERTIES
       LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}"
       LINK_FLAGS "${SHARED_LINK_FLAGS}"
-      OUTPUT_NAME "parquet_arrow")
+      OUTPUT_NAME "parquet_arrow"
+      VERSION "${PARQUET_ABI_VERSION}"
+      SOVERSION "${PARQUET_SO_VERSION}")
     target_link_libraries(parquet_arrow_shared
       arrow
       arrow_io


Mime
View raw message