parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From u..@apache.org
Subject parquet-cpp git commit: PARQUET-894: Fix compilation warnings
Date Tue, 28 Feb 2017 18:41:09 GMT
Repository: parquet-cpp
Updated Branches:
  refs/heads/master d56f4bdeb -> 6d76a5584


PARQUET-894: Fix compilation warnings

Complete commit: dfe1c73c89b8e7e8f87d4c57ba65b79a87fd8766.

Author: Thomas Sanchez <thomas.sanchz@gmail.com>

Closes #262 from daedric/PARQUET-894-reopened and squashes the following commits:

888282b [Thomas Sanchez] PARQUET-894: Fix compilation warnings


Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/6d76a558
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/6d76a558
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/6d76a558

Branch: refs/heads/master
Commit: 6d76a5584d2ba2654158281d506b6187836c1629
Parents: d56f4bd
Author: Thomas Sanchez <thomas.sanchz@gmail.com>
Authored: Tue Feb 28 19:40:55 2017 +0100
Committer: Uwe L. Korn <uwe@apache.org>
Committed: Tue Feb 28 19:40:55 2017 +0100

----------------------------------------------------------------------
 src/parquet/encoding.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/6d76a558/src/parquet/encoding.h
----------------------------------------------------------------------
diff --git a/src/parquet/encoding.h b/src/parquet/encoding.h
index 50a5512..3cea9de 100644
--- a/src/parquet/encoding.h
+++ b/src/parquet/encoding.h
@@ -66,7 +66,7 @@ class Encoder {
   Encoding::type encoding() const { return encoding_; }
 
  protected:
-  explicit Encoder(const ColumnDescriptor* descr, const Encoding::type& encoding,
+  explicit Encoder(const ColumnDescriptor* descr, Encoding::type encoding,
       ::arrow::MemoryPool* pool)
       : descr_(descr), encoding_(encoding), pool_(pool) {}
 
@@ -123,10 +123,10 @@ class Decoder {
   // the number of values left in this page.
   int values_left() const { return num_values_; }
 
-  const Encoding::type encoding() const { return encoding_; }
+  Encoding::type encoding() const { return encoding_; }
 
  protected:
-  explicit Decoder(const ColumnDescriptor* descr, const Encoding::type& encoding)
+  explicit Decoder(const ColumnDescriptor* descr, Encoding::type encoding)
       : descr_(descr), encoding_(encoding), num_values_(0) {}
 
   // For accessing type-specific metadata, like FIXED_LEN_BYTE_ARRAY


Mime
View raw message