parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject parquet-cpp git commit: PARQUET-895: Fix broken reading of nested repeated columns
Date Thu, 23 Feb 2017 17:36:05 GMT
Repository: parquet-cpp
Updated Branches:
  refs/heads/master dfe1c73c8 -> 98f5fa144


PARQUET-895: Fix broken reading of nested repeated columns

Use the column metadata to get the number of levels to process. It
fixes a problem where not enough values are returned in the case
of nested repeated values.

@peshopetrov should get the credit for 1st attempt

Closes #250


Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/98f5fa14
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/98f5fa14
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/98f5fa14

Branch: refs/heads/master
Commit: 98f5fa144f7d1e219c37ebc56e69bc0543457d78
Parents: dfe1c73
Author: Marc Vertes <mvertes@free.fr>
Authored: Thu Feb 23 14:40:43 2017 +0100
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Thu Feb 23 12:35:29 2017 -0500

----------------------------------------------------------------------
 src/parquet/file/reader-internal.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/98f5fa14/src/parquet/file/reader-internal.cc
----------------------------------------------------------------------
diff --git a/src/parquet/file/reader-internal.cc b/src/parquet/file/reader-internal.cc
index 7b821b8..bd3fbea 100644
--- a/src/parquet/file/reader-internal.cc
+++ b/src/parquet/file/reader-internal.cc
@@ -196,7 +196,7 @@ std::unique_ptr<PageReader> SerializedRowGroup::GetColumnPageReader(int
i) {
   stream = properties_.GetStream(source_, col_start, col_length);
 
   return std::unique_ptr<PageReader>(new SerializedPageReader(std::move(stream),
-      row_group_metadata_->num_rows(), col->compression(), properties_.memory_pool()));
+      col->num_values(), col->compression(), properties_.memory_pool()));
 }
 
 // ----------------------------------------------------------------------


Mime
View raw message