parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject [19/50] [abbrv] parquet-mr git commit: PARQUET-423: Replace old Log class with SLF4J Logging
Date Thu, 19 Jan 2017 01:27:30 GMT
http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/main/java/org/apache/parquet/thrift/ParquetWriteProtocol.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ParquetWriteProtocol.java
b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ParquetWriteProtocol.java
index 40984cc..8755ee4 100644
--- a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ParquetWriteProtocol.java
+++ b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ParquetWriteProtocol.java
@@ -18,7 +18,6 @@
  */
 package org.apache.parquet.thrift;
 
-import static org.apache.parquet.Log.DEBUG;
 
 import java.nio.ByteBuffer;
 
@@ -32,7 +31,6 @@ import org.apache.thrift.protocol.TSet;
 import org.apache.thrift.protocol.TStruct;
 import org.apache.thrift.protocol.TType;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.io.ColumnIO;
 import org.apache.parquet.io.GroupColumnIO;
 import org.apache.parquet.io.MessageColumnIO;
@@ -48,6 +46,8 @@ import org.apache.parquet.thrift.struct.ThriftType.ListType;
 import org.apache.parquet.thrift.struct.ThriftType.MapType;
 import org.apache.parquet.thrift.struct.ThriftType.SetType;
 import org.apache.parquet.thrift.struct.ThriftType.StructType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class ParquetWriteProtocol extends ParquetProtocol {
 
@@ -409,7 +409,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
 
   }
 
-  private static final Log LOG = Log.getLog(ParquetWriteProtocol.class);
+  private static final Logger LOG = LoggerFactory.getLogger(ParquetWriteProtocol.class);
 
 
   private final RecordConsumer recordConsumer;
@@ -438,7 +438,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeMessageBegin(TMessage message) throws TException {
-    if (DEBUG) LOG.debug("writeMessageBegin("+message+")");
+    LOG.debug("writeMessageBegin({})", message);
     currentProtocol.writeMessageBegin(message);
   }
 
@@ -448,7 +448,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeMessageEnd() throws TException {
-    if (DEBUG) LOG.debug("writeMessageEnd()");
+    LOG.debug("writeMessageEnd()");
     currentProtocol.writeMessageEnd();
   }
 
@@ -458,7 +458,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeStructBegin(TStruct struct) throws TException {
-    if (DEBUG) LOG.debug("writeStructBegin("+toString(struct)+")");
+    if (LOG.isDebugEnabled()) LOG.debug("writeStructBegin("+toString(struct)+")");
     currentProtocol.writeStructBegin(struct);
   }
 
@@ -468,7 +468,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeStructEnd() throws TException {
-    if (DEBUG) LOG.debug("writeStructEnd()");
+    LOG.debug("writeStructEnd()");
     currentProtocol.writeStructEnd();
   }
 
@@ -478,7 +478,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeFieldBegin(TField field) throws TException {
-    if (DEBUG) LOG.debug("writeFieldBegin("+field+")");
+    LOG.debug("writeFieldBegin({})", field);
     currentProtocol.writeFieldBegin(field);
   }
 
@@ -488,7 +488,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeFieldEnd() throws TException {
-    if (DEBUG) LOG.debug("writeFieldEnd()");
+    LOG.debug("writeFieldEnd()");
     currentProtocol.writeFieldEnd();
   }
 
@@ -498,7 +498,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeFieldStop() throws TException {
-    if (DEBUG) LOG.debug("writeFieldStop()");
+    LOG.debug("writeFieldStop()");
     currentProtocol.writeFieldStop();
   }
 
@@ -508,7 +508,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeMapBegin(TMap map) throws TException {
-    if (DEBUG) LOG.debug("writeMapBegin("+toString(map)+")");
+    if (LOG.isDebugEnabled()) LOG.debug("writeMapBegin("+toString(map)+")");
     currentProtocol.writeMapBegin(map);
   }
 
@@ -518,7 +518,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeMapEnd() throws TException {
-    if (DEBUG) LOG.debug("writeMapEnd()");
+    LOG.debug("writeMapEnd()");
     currentProtocol.writeMapEnd();
   }
 
@@ -528,7 +528,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeListBegin(TList list) throws TException {
-    if (DEBUG) LOG.debug("writeListBegin("+toString(list)+")");
+    if (LOG.isDebugEnabled()) LOG.debug("writeListBegin("+toString(list)+")");
     currentProtocol.writeListBegin(list);
   }
 
@@ -539,7 +539,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeListEnd() throws TException {
-    if (DEBUG) LOG.debug("writeListEnd()");
+    LOG.debug("writeListEnd()");
     currentProtocol.writeListEnd();
   }
 
@@ -550,7 +550,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeSetBegin(TSet set) throws TException {
-    if (DEBUG) LOG.debug("writeSetBegin("+set+")");
+    LOG.debug("writeSetBegin({})", set);
     currentProtocol.writeSetBegin(set);
   }
 
@@ -560,7 +560,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeSetEnd() throws TException {
-    if (DEBUG) LOG.debug("writeSetEnd()");
+    LOG.debug("writeSetEnd()");
     currentProtocol.writeSetEnd();
   }
 
@@ -570,7 +570,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeBool(boolean b) throws TException {
-    if (DEBUG) LOG.debug("writeBool("+b+")");
+    LOG.debug("writeBool({})", b);
     currentProtocol.writeBool(b);
   }
 
@@ -580,7 +580,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeByte(byte b) throws TException {
-    if (DEBUG) LOG.debug("writeByte("+b+")");
+    LOG.debug("writeByte({})", b);
     currentProtocol.writeByte(b);
   }
 
@@ -590,7 +590,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeI16(short i16) throws TException {
-    if (DEBUG) LOG.debug("writeI16("+i16+")");
+    LOG.debug("writeI16({})", i16);
     currentProtocol.writeI16(i16);
   }
 
@@ -600,7 +600,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeI32(int i32) throws TException {
-    if (DEBUG) LOG.debug("writeI32("+i32+")");
+    LOG.debug("writeI32({})", i32);
     currentProtocol.writeI32(i32);
   }
 
@@ -610,7 +610,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeI64(long i64) throws TException {
-    if (DEBUG) LOG.debug("writeI64("+i64+")");
+    LOG.debug("writeI64({})", i64);
     currentProtocol.writeI64(i64);
   }
 
@@ -620,7 +620,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeDouble(double dub) throws TException {
-    if (DEBUG) LOG.debug("writeDouble("+dub+")");
+    LOG.debug("writeDouble({})", dub);
     currentProtocol.writeDouble(dub);
   }
 
@@ -630,7 +630,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeString(String str) throws TException {
-    if (DEBUG) LOG.debug("writeString("+str+")");
+    LOG.debug("writeString({})", str);
     currentProtocol.writeString(str);
   }
 
@@ -640,7 +640,7 @@ public class ParquetWriteProtocol extends ParquetProtocol {
    */
   @Override
   public void writeBinary(ByteBuffer buf) throws TException {
-    if (DEBUG) LOG.debug("writeBinary("+buf+")");
+    LOG.debug("writeBinary({})", buf);
     currentProtocol.writeBinary(buf);
   }
 

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftMetaData.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftMetaData.java b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftMetaData.java
index f0a9624..e39b649 100644
--- a/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftMetaData.java
+++ b/parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftMetaData.java
@@ -19,10 +19,11 @@
 package org.apache.parquet.thrift;
 import java.util.*;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.hadoop.BadConfigurationException;
 import org.apache.parquet.thrift.struct.ThriftType;
 import org.apache.parquet.thrift.struct.ThriftType.StructType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  *
@@ -32,7 +33,7 @@ import org.apache.parquet.thrift.struct.ThriftType.StructType;
  *
  */
 public class ThriftMetaData {
-  private static final Log LOG = Log.getLog(ThriftMetaData.class);
+  private static final Logger LOG = LoggerFactory.getLogger(ThriftMetaData.class);
 
   private static final String THRIFT_CLASS = "thrift.class";
   private static final String THRIFT_DESCRIPTOR = "thrift.descriptor";

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/StrictFieldProjectionFilter.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/StrictFieldProjectionFilter.java
b/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/StrictFieldProjectionFilter.java
index 645ae96..b048f16 100644
--- a/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/StrictFieldProjectionFilter.java
+++ b/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/StrictFieldProjectionFilter.java
@@ -21,9 +21,10 @@ package org.apache.parquet.thrift.projection;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.Strings;
 import org.apache.parquet.glob.WildcardPath;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Stricter Implementation of {@link FieldProjectionFilter}.
@@ -38,7 +39,7 @@ import org.apache.parquet.glob.WildcardPath;
  * throw when {@link #assertNoUnmatchedPatterns()} is called.
  */
 public class StrictFieldProjectionFilter implements FieldProjectionFilter {
-  private static final Log LOG = Log.getLog(FieldProjectionFilter.class);
+  private static final Logger LOG = LoggerFactory.getLogger(FieldProjectionFilter.class);
   private static final String GLOB_SEPARATOR = ";";
 
   // use a list instead of a Set, so we can detect overlapping patterns and

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestInputOutputFormat.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestInputOutputFormat.java
b/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestInputOutputFormat.java
index 0835cdb..af8e60d 100644
--- a/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestInputOutputFormat.java
+++ b/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestInputOutputFormat.java
@@ -45,7 +45,6 @@ import org.apache.hadoop.mapreduce.lib.output.TextOutputFormat;
 import org.apache.thrift.TBase;
 import org.junit.Test;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.example.data.Group;
 import org.apache.parquet.hadoop.metadata.CompressionCodecName;
 import org.apache.parquet.thrift.test.compat.StructV1;
@@ -56,9 +55,11 @@ import com.twitter.data.proto.tutorial.thrift.AddressBook;
 import com.twitter.data.proto.tutorial.thrift.Name;
 import com.twitter.data.proto.tutorial.thrift.Person;
 import com.twitter.data.proto.tutorial.thrift.PhoneNumber;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class TestInputOutputFormat {
-  private static final Log LOG = Log.getLog(TestInputOutputFormat.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TestInputOutputFormat.class);
 
   public static AddressBook nextAddressbook(int i) {
     final ArrayList<Person> persons = new ArrayList<Person>();
@@ -245,10 +246,10 @@ public class TestInputOutputFormat {
   public static void waitForJob(Job job) throws Exception {
     job.submit();
     while (!job.isComplete()) {
-      LOG.debug("waiting for job " + job.getJobName());
+      LOG.debug("waiting for job {}", job.getJobName());
       sleep(100);
     }
-    LOG.info("status for job " + job.getJobName() + ": " + (job.isSuccessful() ? "SUCCESS"
: "FAILURE"));
+    LOG.info("status for job {}: {}", job.getJobName(), (job.isSuccessful() ? "SUCCESS" :
"FAILURE"));
     if (!job.isSuccessful()) {
       throw new RuntimeException("job failed " + job.getJobName());
     }

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java
b/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java
index 4869460..eaef499 100644
--- a/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java
+++ b/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java
@@ -38,10 +38,11 @@ import org.apache.thrift.protocol.TProtocol;
 import org.apache.thrift.protocol.TProtocolFactory;
 import org.apache.thrift.transport.TIOStreamTransport;
 import org.junit.Test;
-import org.apache.parquet.Log;
 import org.apache.parquet.hadoop.api.ReadSupport;
 import org.apache.parquet.hadoop.util.ContextUtil;
 import org.apache.parquet.thrift.test.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayOutputStream;
 import java.util.*;
@@ -50,7 +51,7 @@ import static org.junit.Assert.assertEquals;
 
 public class TestParquetToThriftReadWriteAndProjection {
 
-  private static final Log LOG = Log.getLog(TestParquetToThriftReadWriteAndProjection.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TestParquetToThriftReadWriteAndProjection.class);
 
   @Test
   public void testThriftOptionalFieldsWithReadProjectionUsingParquetSchema() throws Exception
{
@@ -374,7 +375,7 @@ public class TestParquetToThriftReadWriteAndProjection {
       reader.initialize(split, taskAttemptContext);
       if (reader.nextKeyValue()) {
         readValue = reader.getCurrentValue();
-        LOG.info(readValue);
+        LOG.info("{}", readValue);
       }
     }
     assertEquals(exptectedReadResult, readValue);

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestThriftToParquetFileWriter.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestThriftToParquetFileWriter.java
b/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestThriftToParquetFileWriter.java
index 2407e61..0439686 100644
--- a/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestThriftToParquetFileWriter.java
+++ b/parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestThriftToParquetFileWriter.java
@@ -50,7 +50,6 @@ import org.apache.thrift.protocol.TProtocolFactory;
 import org.apache.thrift.transport.TIOStreamTransport;
 import org.junit.Test;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.example.data.Group;
 import org.apache.parquet.hadoop.ParquetFileReader;
 import org.apache.parquet.hadoop.ParquetReader;
@@ -65,10 +64,11 @@ import com.twitter.elephantbird.thrift.test.TestListInMap;
 import com.twitter.elephantbird.thrift.test.TestMapInList;
 
 import org.apache.parquet.schema.MessageType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class TestThriftToParquetFileWriter {
-  private static final Log LOG = Log
-      .getLog(TestThriftToParquetFileWriter.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TestThriftToParquetFileWriter.class);
 
   @Test
   public void testWriteFile() throws IOException, InterruptedException, TException {
@@ -270,7 +270,7 @@ public class TestThriftToParquetFileWriter {
 
   private <T extends TBase<?,?>> Path createFile(T... tObjs) throws IOException,
InterruptedException, TException  {
     final Path fileToCreate = new Path("target/test/TestThriftToParquetFileWriter/"+tObjs[0].getClass()+".parquet");
-    LOG.info("File created: " + fileToCreate.toString());
+    LOG.info("File created: {}", fileToCreate.toString());
     Configuration conf = new Configuration();
     final FileSystem fs = fileToCreate.getFileSystem(conf);
     if (fs.exists(fileToCreate)) {

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetReadProtocol.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetReadProtocol.java
b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetReadProtocol.java
index 97e0054..b713058 100644
--- a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetReadProtocol.java
+++ b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetReadProtocol.java
@@ -32,13 +32,14 @@ import java.util.Map;
 import java.util.Set;
 
 import org.apache.parquet.column.ParquetProperties;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import thrift.test.OneOfEach;
 
 import org.apache.thrift.TBase;
 import org.apache.thrift.TException;
 import org.junit.Test;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.column.impl.ColumnWriteStoreV1;
 import org.apache.parquet.column.page.mem.MemPageStore;
 import org.apache.parquet.io.ColumnIOFactory;
@@ -61,7 +62,7 @@ import com.twitter.elephantbird.thrift.test.TestPhoneType;
 import com.twitter.elephantbird.thrift.test.TestStructInMap;
 
 public class TestParquetReadProtocol {
-  private static final Log LOG = Log.getLog(TestParquetReadProtocol.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TestParquetReadProtocol.class);
 
   @Test
   public void testList() throws TException {
@@ -146,7 +147,7 @@ public class TestParquetReadProtocol {
     final MemPageStore memPageStore = new MemPageStore(1);
     final ThriftSchemaConverter schemaConverter = new ThriftSchemaConverter();
     final MessageType schema = schemaConverter.convert(thriftClass);
-    LOG.info(schema);
+    LOG.info("{}", schema);
     final MessageColumnIO columnIO = new ColumnIOFactory(true).getColumnIO(schema);
     final ColumnWriteStoreV1 columns = new ColumnWriteStoreV1(memPageStore,
         ParquetProperties.builder()

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetWriteProtocol.java
----------------------------------------------------------------------
diff --git a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetWriteProtocol.java
b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetWriteProtocol.java
index 320d3a3..df60766 100644
--- a/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetWriteProtocol.java
+++ b/parquet-thrift/src/test/java/org/apache/parquet/thrift/TestParquetWriteProtocol.java
@@ -31,6 +31,8 @@ import java.util.Set;
 import java.util.TreeMap;
 
 import org.junit.ComparisonFailure;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import thrift.test.OneOfEach;
 
 import org.apache.pig.data.Tuple;
@@ -39,7 +41,6 @@ import org.apache.thrift.TBase;
 import org.apache.thrift.TException;
 import org.junit.Test;
 
-import org.apache.parquet.Log;
 import org.apache.parquet.io.ColumnIOFactory;
 import org.apache.parquet.io.ExpectationValidatingRecordConsumer;
 import org.apache.parquet.io.MessageColumnIO;
@@ -67,7 +68,7 @@ import com.twitter.elephantbird.thrift.test.TestStructInMap;
 
 
 public class TestParquetWriteProtocol {
-  private static final Log LOG = Log.getLog(TestParquetWriteProtocol.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TestParquetWriteProtocol.class);
   @Test
   public void testMap() throws Exception {
     String[] expectations = {
@@ -523,7 +524,7 @@ public class TestParquetWriteProtocol {
 //      System.out.println(a);
     final Class<TBase<?,?>> class1 = (Class<TBase<?,?>>)a.getClass();
     final MessageType schema = thriftSchemaConverter.convert(class1);
-    LOG.info(schema);
+    LOG.info("{}", schema);
     final StructType structType = thriftSchemaConverter.toStructType(class1);
     ExpectationValidatingRecordConsumer recordConsumer = new ExpectationValidatingRecordConsumer(new
ArrayDeque<String>(Arrays.asList(expectations)));
     final MessageColumnIO columnIO = new ColumnIOFactory().getColumnIO(schema);
@@ -535,14 +536,14 @@ public class TestParquetWriteProtocol {
     ThriftToPig<TBase<?,?>> thriftToPig = new ThriftToPig(a.getClass());
     ExpectationValidatingRecordConsumer recordConsumer = new ExpectationValidatingRecordConsumer(new
ArrayDeque<String>(Arrays.asList(expectations)));
     Schema pigSchema = thriftToPig.toSchema();
-    LOG.info(pigSchema);
+    LOG.info("{}", pigSchema);
     MessageType schema = new PigSchemaConverter().convert(pigSchema);
-    LOG.info(schema);
+    LOG.info("{}", schema);
     TupleWriteSupport tupleWriteSupport = new TupleWriteSupport(pigSchema);
     tupleWriteSupport.init(null);
     tupleWriteSupport.prepareForWrite(recordConsumer);
     final Tuple pigTuple = thriftToPig.getPigTuple(a);
-    LOG.info(pigTuple);
+    LOG.info("{}", pigTuple);
     tupleWriteSupport.write(pigTuple);
     return schema;
   }

http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8e2009b8/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 9769c18..e6977fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -172,7 +172,6 @@
           <aggregate>true</aggregate>
           <instrumentation>
             <ignores>
-              <ignore>org.apache.parquet.Log.*</ignore>
               <ignore>java.lang.UnsupportedOperationException.*</ignore>
             </ignores>
             <excludes>


Mime
View raw message