parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject [17/50] [abbrv] parquet-mr git commit: PARQUET-581: Fix two instances of the conflation of the min and max row
Date Thu, 19 Jan 2017 01:27:28 GMT
PARQUET-581: Fix two instances of the conflation of the min and max row

count for page size check in ParquetOutputFormat.java

Author: Michael Allman <michael@videoamp.com>

Closes #340 from mallman/fix_minmax_conflation and squashes the following commits:

79331a5 [Michael Allman] PARQUET-581: Fix two instances of the conflation of the min and max
row count for page size check in ParquetOutputFormat.java


Project: http://git-wip-us.apache.org/repos/asf/parquet-mr/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-mr/commit/1c60a566
Tree: http://git-wip-us.apache.org/repos/asf/parquet-mr/tree/1c60a566
Diff: http://git-wip-us.apache.org/repos/asf/parquet-mr/diff/1c60a566

Branch: refs/heads/parquet-1.8.x
Commit: 1c60a5666c3d82b4a4d4dfc9f0bb9ca0f7b3a194
Parents: 43d0961
Author: Michael Allman <michael@videoamp.com>
Authored: Sat Apr 16 17:23:59 2016 -0700
Committer: Ryan Blue <blue@apache.org>
Committed: Mon Jan 9 16:54:53 2017 -0800

----------------------------------------------------------------------
 .../main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/1c60a566/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
----------------------------------------------------------------------
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
index 6cd4c90..e95a508 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
@@ -203,7 +203,7 @@ public class ParquetOutputFormat<T> extends FileOutputFormat<Void,
T> {
 
   public static int getMaxRowCountForPageSizeCheck(Configuration configuration) {
     return configuration.getInt(MAX_ROW_COUNT_FOR_PAGE_SIZE_CHECK,
-        ParquetProperties.DEFAULT_MINIMUM_RECORD_COUNT_FOR_CHECK);
+        ParquetProperties.DEFAULT_MAXIMUM_RECORD_COUNT_FOR_CHECK);
   }
 
   public static boolean getEstimatePageSizeCheck(Configuration configuration) {
@@ -334,7 +334,7 @@ public class ParquetOutputFormat<T> extends FileOutputFormat<Void,
T> {
     if (INFO) LOG.info("Maximum row group padding size is " + maxPaddingSize + " bytes");
     if (INFO) LOG.info("Page size checking is: " + (props.estimateNextSizeCheck() ? "estimated"
: "constant"));
     if (INFO) LOG.info("Min row count for page size check is: " + props.getMinRowCountForPageSizeCheck());
-    if (INFO) LOG.info("Min row count for page size check is: " + props.getMaxRowCountForPageSizeCheck());
+    if (INFO) LOG.info("Max row count for page size check is: " + props.getMaxRowCountForPageSizeCheck());
 
     WriteContext init = writeSupport.init(conf);
     ParquetFileWriter w = new ParquetFileWriter(


Mime
View raw message