Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2F0A200BAD for ; Tue, 11 Oct 2016 04:45:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D1AF7160AEB; Tue, 11 Oct 2016 02:45:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 25983160AE1 for ; Tue, 11 Oct 2016 04:45:55 +0200 (CEST) Received: (qmail 49775 invoked by uid 500); 11 Oct 2016 02:45:55 -0000 Mailing-List: contact commits-help@parquet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@parquet.apache.org Delivered-To: mailing list commits@parquet.apache.org Received: (qmail 49766 invoked by uid 99); 11 Oct 2016 02:45:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2016 02:45:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3EF95DFE13; Tue, 11 Oct 2016 02:45:55 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: wesm@apache.org To: commits@parquet.apache.org Message-Id: <93acfaf1a20a4bb5b3ed6b8b9cd5b25d@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: parquet-cpp git commit: PARQUET-739: Don't use a static buffer for data accessed by multiple threads Date: Tue, 11 Oct 2016 02:45:55 +0000 (UTC) archived-at: Tue, 11 Oct 2016 02:45:57 -0000 Repository: parquet-cpp Updated Branches: refs/heads/master ac4e80c97 -> a26ed0f17 PARQUET-739: Don't use a static buffer for data accessed by multiple threads I am hitting this problem at another location too. Author: Deepak Majeti Closes #177 from majetideepak/PARQUET-739 and squashes the following commits: 85a73f1 [Deepak Majeti] PARQUET-739 Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/a26ed0f1 Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/a26ed0f1 Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/a26ed0f1 Branch: refs/heads/master Commit: a26ed0f179c3ecab662a8c760504a3e370a4dc02 Parents: ac4e80c Author: Deepak Majeti Authored: Mon Oct 10 22:45:49 2016 -0400 Committer: Wes McKinney Committed: Mon Oct 10 22:45:49 2016 -0400 ---------------------------------------------------------------------- src/parquet/util/bit-stream-utils.inline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/a26ed0f1/src/parquet/util/bit-stream-utils.inline.h ---------------------------------------------------------------------- diff --git a/src/parquet/util/bit-stream-utils.inline.h b/src/parquet/util/bit-stream-utils.inline.h index 5cdf76b..c3486f7 100644 --- a/src/parquet/util/bit-stream-utils.inline.h +++ b/src/parquet/util/bit-stream-utils.inline.h @@ -149,7 +149,7 @@ inline int BitReader::GetBatch(int num_bits, T* v, int batch_size) { byte_offset += num_unpacked * num_bits / 8; } else { const int buffer_size = 1024; - static uint32_t unpack_buffer[buffer_size]; + uint32_t unpack_buffer[buffer_size]; while (i < batch_size) { int unpack_size = std::min(buffer_size, batch_size - i); int num_unpacked = unpack32(reinterpret_cast(buffer + byte_offset),