Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CBF1A200B11 for ; Mon, 13 Jun 2016 21:31:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CA784160A3C; Mon, 13 Jun 2016 19:31:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F9AB160A1A for ; Mon, 13 Jun 2016 21:31:15 +0200 (CEST) Received: (qmail 92725 invoked by uid 500); 13 Jun 2016 19:31:15 -0000 Mailing-List: contact commits-help@parquet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@parquet.apache.org Delivered-To: mailing list commits@parquet.apache.org Received: (qmail 92716 invoked by uid 99); 13 Jun 2016 19:31:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 19:31:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3458EDFBA8; Mon, 13 Jun 2016 19:31:15 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: wesm@apache.org To: commits@parquet.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: parquet-cpp git commit: PARQUET-630: Support link flags for older CMake versions Date: Mon, 13 Jun 2016 19:31:15 +0000 (UTC) archived-at: Mon, 13 Jun 2016 19:31:17 -0000 Repository: parquet-cpp Updated Branches: refs/heads/master dd555cdfe -> 5f07b4faf PARQUET-630: Support link flags for older CMake versions Author: Uwe L. Korn Closes #118 from xhochy/parquet-630 and squashes the following commits: 89072d6 [Uwe L. Korn] PARQUET-630: Support link flags for older CMake versions Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/5f07b4fa Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/5f07b4fa Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/5f07b4fa Branch: refs/heads/master Commit: 5f07b4faf915946e1432625a1293b23021633d1b Parents: dd555cd Author: Uwe L. Korn Authored: Mon Jun 13 12:31:07 2016 -0700 Committer: Wes McKinney Committed: Mon Jun 13 12:31:07 2016 -0700 ---------------------------------------------------------------------- CMakeLists.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/5f07b4fa/CMakeLists.txt ---------------------------------------------------------------------- diff --git a/CMakeLists.txt b/CMakeLists.txt index d4cf68f..a9b930e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -484,8 +484,8 @@ if (PARQUET_BUILD_SHARED) PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}" OUTPUT_NAME "parquet") - target_link_libraries(parquet_shared PUBLIC ${LIBPARQUET_LINK_LIBS}) - target_link_libraries(parquet_shared PRIVATE ${LIBPARQUET_PRIVATE_LINK_LIBS}) + target_link_libraries(parquet_shared LINK_PUBLIC ${LIBPARQUET_LINK_LIBS}) + target_link_libraries(parquet_shared LINK_PRIVATE ${LIBPARQUET_PRIVATE_LINK_LIBS}) endif() if (PARQUET_BUILD_STATIC) @@ -494,8 +494,8 @@ if (PARQUET_BUILD_STATIC) PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}" OUTPUT_NAME "parquet") - target_link_libraries(parquet_static PUBLIC ${LIBPARQUET_LINK_LIBS}) - target_link_libraries(parquet_static PRIVATE ${LIBPARQUET_PRIVATE_LINK_LIBS}) + target_link_libraries(parquet_static LINK_PUBLIC ${LIBPARQUET_LINK_LIBS}) + target_link_libraries(parquet_static LINK_PRIVATE ${LIBPARQUET_PRIVATE_LINK_LIBS}) endif() add_subdirectory(src/parquet)