parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject parquet-cpp git commit: PARQUET-638: Temporarily disable static linking libstdc++ in the conda builds
Date Thu, 23 Jun 2016 05:28:28 GMT
Repository: parquet-cpp
Updated Branches:
  refs/heads/master 53475c71a -> dc436c476


PARQUET-638: Temporarily disable static linking libstdc++ in the conda builds

We can re-enable this after we've addressed visibility macros.

Author: Wes McKinney <wesm@apache.org>

Closes #124 from wesm/PARQUET-638 and squashes the following commits:

b55dfb8 [Wes McKinney] Temporarily disable static linking libstdc++


Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/dc436c47
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/dc436c47
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/dc436c47

Branch: refs/heads/master
Commit: dc436c476c6d049a159ce8c92a7a54735ab0e2a5
Parents: 53475c7
Author: Wes McKinney <wesm@apache.org>
Authored: Wed Jun 22 22:28:21 2016 -0700
Committer: Wes McKinney <wesm@apache.org>
Committed: Wed Jun 22 22:28:21 2016 -0700

----------------------------------------------------------------------
 conda.recipe/build.sh | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/dc436c47/conda.recipe/build.sh
----------------------------------------------------------------------
diff --git a/conda.recipe/build.sh b/conda.recipe/build.sh
index cadf512..2ba5c77 100644
--- a/conda.recipe/build.sh
+++ b/conda.recipe/build.sh
@@ -45,11 +45,13 @@ export PARQUET_INSECURE_CURL=1
 source thirdparty/versions.sh
 export GTEST_HOME=`pwd`/thirdparty/$GTEST_BASEDIR
 
-if [ `uname` == Linux ]; then
-    SHARED_LINKER_FLAGS='-static-libstdc++'
-elif [ `uname` == Darwin ]; then
-    SHARED_LINKER_FLAGS=''
-fi
+# PARQUET-638, PARQUET-489: This should be restored after symbol visibility is
+# hidden by default
+# if [ `uname` == Linux ]; then
+#     SHARED_LINKER_FLAGS='-static-libstdc++'
+# elif [ `uname` == Darwin ]; then
+#     SHARED_LINKER_FLAGS=''
+# fi
 
 cmake \
     -DCMAKE_BUILD_TYPE=release \


Mime
View raw message