Return-Path: X-Original-To: apmail-parquet-commits-archive@minotaur.apache.org Delivered-To: apmail-parquet-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E1FD187B3 for ; Sun, 13 Mar 2016 17:45:13 +0000 (UTC) Received: (qmail 8258 invoked by uid 500); 13 Mar 2016 17:45:13 -0000 Delivered-To: apmail-parquet-commits-archive@parquet.apache.org Received: (qmail 8220 invoked by uid 500); 13 Mar 2016 17:45:13 -0000 Mailing-List: contact commits-help@parquet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@parquet.apache.org Delivered-To: mailing list commits@parquet.apache.org Received: (qmail 8211 invoked by uid 99); 13 Mar 2016 17:45:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Mar 2016 17:45:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 02F7CDFF8E; Sun, 13 Mar 2016 17:45:13 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: wesm@apache.org To: commits@parquet.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: parquet-cpp git commit: PARQUET-561: Add destructor to PIMPL Date: Sun, 13 Mar 2016 17:45:13 +0000 (UTC) Repository: parquet-cpp Updated Branches: refs/heads/master caf2576ce -> 86b016885 PARQUET-561: Add destructor to PIMPL Without this destuctor, the SerializedFile class cannot be destructed and leaks memory. Author: Uwe L. Korn Closes #77 from xhochy/destructor-for-pimpl and squashes the following commits: 0f80966 [Uwe L. Korn] Add destructor to PIMPL Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/86b01688 Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/86b01688 Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/86b01688 Branch: refs/heads/master Commit: 86b0168859124df608c41c2d528d62fb85e31903 Parents: caf2576 Author: Uwe L. Korn Authored: Sun Mar 13 10:44:54 2016 -0700 Committer: Wes McKinney Committed: Sun Mar 13 10:44:54 2016 -0700 ---------------------------------------------------------------------- src/parquet/file/reader.h | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/86b01688/src/parquet/file/reader.h ---------------------------------------------------------------------- diff --git a/src/parquet/file/reader.h b/src/parquet/file/reader.h index 94f5931..18b052a 100644 --- a/src/parquet/file/reader.h +++ b/src/parquet/file/reader.h @@ -69,6 +69,7 @@ class ParquetFileReader { public: // Forward declare the PIMPL struct Contents { + virtual ~Contents() {} // Perform any cleanup associated with the file contents virtual void Close() = 0;