parquet-commits mailing list archives

Repository: parquet-mr
Updated Branches:
  refs/heads/master 013b445ed -> f4e754e66


PARQUET-324: row count incorrect if data file has more than 2^31 rows

Need to change numRows counter from int to long to account for input files with more than
2^31 rows.

Author: Thomas Friedrich <tfriedr@us.ibm.com>

Closes #233 from tfriedr/parquet-324 and squashes the following commits:

0120205 [Thomas Friedrich] change numRows from int to long


Project: http://git-wip-us.apache.org/repos/asf/parquet-mr/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-mr/commit/f4e754e6
Tree: http://git-wip-us.apache.org/repos/asf/parquet-mr/tree/f4e754e6
Diff: http://git-wip-us.apache.org/repos/asf/parquet-mr/diff/f4e754e6

Branch: refs/heads/master
Commit: f4e754e66e3661274df624bc328991cd88dd03d6
Parents: 013b445
Author: Thomas Friedrich <tfriedr@us.ibm.com>
Authored: Fri Jul 3 10:53:22 2015 -0700
Committer: Ryan Blue <blue@apache.org>
Committed: Fri Jul 3 10:53:22 2015 -0700

----------------------------------------------------------------------
 .../apache/parquet/format/converter/ParquetMetadataConverter.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/f4e754e6/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
----------------------------------------------------------------------
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
b/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
index e8b6d73..fdeb2ba 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
@@ -89,7 +89,7 @@ public class ParquetMetadataConverter {
   public FileMetaData toParquetMetadata(int currentVersion, ParquetMetadata parquetMetadata)
{
     List<BlockMetaData> blocks = parquetMetadata.getBlocks();
     List<RowGroup> rowGroups = new ArrayList<RowGroup>();
-    int numRows = 0;
+    long numRows = 0;
     for (BlockMetaData block : blocks) {
       numRows += block.getRowCount();
       addRowGroup(parquetMetadata, rowGroups, block);