parquet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject incubator-parquet-format git commit: PARQUET-240: Fix typo in the LIST description
Date Sat, 04 Apr 2015 17:39:47 GMT
Repository: incubator-parquet-format
Updated Branches:
  refs/heads/master ce4de847a -> ea0952265


PARQUET-240: Fix typo in the LIST description

The description mistakenly refers to the repeated element being named "array"
instead of "list". This also fixes one grammatical error.

Author: Colin Marc <colinmarc@gmail.com>

Closes #25 from colinmarc/fix-list-typo and squashes the following commits:

5c36271 [Colin Marc] Fix typo in the LIST description


Project: http://git-wip-us.apache.org/repos/asf/incubator-parquet-format/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-parquet-format/commit/ea095226
Tree: http://git-wip-us.apache.org/repos/asf/incubator-parquet-format/tree/ea095226
Diff: http://git-wip-us.apache.org/repos/asf/incubator-parquet-format/diff/ea095226

Branch: refs/heads/master
Commit: ea095226597fdbecd60c2419d96b54b2fdb4ae6c
Parents: ce4de84
Author: Colin Marc <colinmarc@gmail.com>
Authored: Sat Apr 4 10:39:43 2015 -0700
Committer: Ryan Blue <blue@apache.org>
Committed: Sat Apr 4 10:39:43 2015 -0700

----------------------------------------------------------------------
 LogicalTypes.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-parquet-format/blob/ea095226/LogicalTypes.md
----------------------------------------------------------------------
diff --git a/LogicalTypes.md b/LogicalTypes.md
index 6bbd27a..413a9ca 100644
--- a/LogicalTypes.md
+++ b/LogicalTypes.md
@@ -220,7 +220,7 @@ optional group array_of_arrays (LIST) {
 
 #### Backward-compatibility rules
 
-It is required that the repeated group of elements is named `array` and that
+It is required that the repeated group of elements is named `list` and that
 its element field is named `element`. However, these names may not be used in
 existing data and should not be enforced as errors when reading. For example,
 the following field schema should produce a nullable list of non-null strings,
@@ -234,16 +234,16 @@ optional group my_list (LIST) {
 }
 ```
 
-Some existing data did not include the inner element layer. For
+Some existing data does not include the inner element layer. For
 backward-compatibility, the type of elements in `LIST`-annotated structures
-should always be determined by the following rules based on the repeated field:
+should always be determined by the following rules:
 
 1. If the repeated field is not a group, then its type is the element type and
    elements are required.
 2. If the repeated field is a group with multiple fields, then its type is the
    element type and elements are required.
-3. If the repeated field is a group with one field and is named either "array"
-   or uses the `LIST`-annotated group's name with "tuple" appended then the
+3. If the repeated field is a group with one field and is named either `array`
+   or uses the `LIST`-annotated group's name with `_tuple` appended then the
    repeated type is the element type and elements are required.
 4. Otherwise, the repeated field's type is the element type with the repeated
    field's repetition.


Mime
View raw message