pagespeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1681: Uncacheable content, preventing rewriting of image
Date Thu, 05 Mar 2020 09:33:55 GMT
Lofesa commented on issue #1681: Uncacheable content, preventing rewriting of image
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1681#issuecomment-595124972
 
 
   Well... In the LoadfromFile path some others directives must be set.
   Why don´t simplyfy?
   
   ```
   ModPagespeedLoadFromFile "https://www.weedstreet420.com/" \
   "/var/www/vhosts/weedstreet420.com/httpdocs/web/" 
   ```
   Some rules you can test:
   
   `ModPagespeedLoadFromFileRuleMatch Disallow  .*` # (this disallow all files) 
   `ModPagespeedLoadFromFileRuleMatch  \.(js|css|jpg|jpeg|png|pdf|gif)$` (This allow any file
with these extensions. You need to change to extensions files you use)
   The order of these directives make sense. 
   
   `ModPagespeedLoadFromFileCacheTtlMs 604800000`
   When you load files from disk, these don´t have any http headers, with this directive,
you set the ttl for a week (the time you put here is in miliseconds)... is like cache-control:
604800000.
   
   Find the docs from these directives and set it to fit your need.
   
   Now you can see some images still unoptimized, like organigram-holdings-inc-potstock-cannabis-investing.png.
   That is a spected behaviour. These files uses data-srcset and these label is not optimized.
Take a look at the html code. You can see that srcset behind the nonscript tag are rewrited,
or data-src, but not the data-srcset. In the pagespeed version you use data-srcset are not
optimized. A new version is next to public release (v1.14.36.1) with this version data-srcset
is optimized too.
   
   With LoadFromFile, each request run stat() to check the file, if the file changes, pagespeed
reload it again.
   
   Good luck.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message