pagespeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] oschaaf commented on issue #1697: Add CspPolicy::ToIdentityString(). Use it in JS Combiner cache key suffix
Date Thu, 01 Jan 1970 00:00:00 GMT
oschaaf commented on issue #1697: Add CspPolicy::ToIdentityString(). Use it in JS Combiner
cache key suffix
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1697#issuecomment-357796379
 
 
   I'll take a closer look at empty vs missing, and also at the delimiters used while constructing
the identity string for hashing, thanks for pointing these things out.
   
   Also you're right: it should be possible to optimize this by only considering pairs we
care about when computing the cache key. combine_js would only care about (potentially) script-related
directives, I think? 
   
   Currently this change only has wired up `js_combine_filter.cc` to materialize something
concrete.. when we're happy with the way this works and looks, I'll look into making changes
to other filters.
   
   Lastly, +1 to continue render time checking, absolutely.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message