From dev-return-2823-archive-asf-public=cust-asf.ponee.io@orc.apache.org Fri May 31 07:43:33 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 19A1A180627 for ; Fri, 31 May 2019 09:43:32 +0200 (CEST) Received: (qmail 20400 invoked by uid 500); 31 May 2019 07:43:29 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 20388 invoked by uid 99); 31 May 2019 07:43:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 May 2019 07:43:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 52D8AC5534 for ; Fri, 31 May 2019 07:43:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id M_I5tEN_KdXu for ; Fri, 31 May 2019 07:43:26 +0000 (UTC) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1A69C5F173 for ; Fri, 31 May 2019 07:43:26 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id h2so331965pgg.1 for ; Fri, 31 May 2019 00:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ixUaMeTGUo9/IYWMoX1KeisnrjRCB9c1z7AvCxKFvs8=; b=YrxNTHNY/frc+rn9tZALSNj3RGLOh9KvYClkUQnX/UEZ7F7l2f26RRPWZQ4Hot+KOV rgrLSXsDLwmqKuiAU8KIzepUraQFC7ZaicjriMAm7M/m9oOfKqkNS1eYqn0EVHoEvjHM kqR3jJRI03LewX4Rw9DRIkAAihd/JIRY8GR4hRzyLFoa3axJJV+OIhHGE9sJuLvcagZR 3i56saTaeb1PmbNFImwjn0svk8++Z8itEbA/A/PIYs7uZiwCtcaZz73wWhr4ACyCZCJl HBKY8cwplsQvkvOaXXp604rk7/qN+zJmmOW4hfalIXAkKn834StWoFjYJmcyuzKI2UJK dhBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ixUaMeTGUo9/IYWMoX1KeisnrjRCB9c1z7AvCxKFvs8=; b=djgg5S18O6MpUYnh9AFPwVQSJBTRSWvVc8MyMzqwrz2152HvitmmewAK8+2iI/+sHs RlTHPcYDkUdprWCCcIW2TDAcC9aeImPSLoiCUcHCS6tJW5D4XAm+9XQIxBPmuRkhEe8r rBINWQ2fDUGUzM9yI8p+Izbz/Gtp71hV8q4rt7Vnl/NcT+CNYAVtgzlY5ZklMfaimdh9 hyVyS5GTYqH1bOFH2CIbefVIKSUyV168/pNi8nfjoFnn1MRkbkLCi5pQo7fpC5867TAm TKqTSmrSoRtZeXfbNJ5JJI+nPm0Bwbq+S/TdT//TJxoDEeTxYIyF/SQWb98oEIYzYFY4 XXVw== X-Gm-Message-State: APjAAAUVTTEcrxm5Ev4XZF7UaYJRwIHiAN5hgOw66UtXcer55eZkG5gz 6CTBlNlIcFlpyPYY98eJk6Q2ItJCF/tUD59xd9esWXuR X-Google-Smtp-Source: APXvYqyiwXLy8xrc5FqbMCAJ50IPAdf1k9v/jU7SAjy8KVpqnQXpZMTj+taC7FHx3wP/4F5/c2F3o5g12gbV9ft2U8c= X-Received: by 2002:a62:2a0a:: with SMTP id q10mr7659196pfq.79.1559288604381; Fri, 31 May 2019 00:43:24 -0700 (PDT) MIME-Version: 1.0 References: <7d589200-d59c-4ad2-90c2-5c927e512b6a@Spark> In-Reply-To: <7d589200-d59c-4ad2-90c2-5c927e512b6a@Spark> From: naveen mahadevuni Date: Fri, 31 May 2019 13:13:13 +0530 Message-ID: Subject: Re: Sub-classing implementation classes(e.g., ReaderImpl) To: dev@orc.apache.org Content-Type: multipart/alternative; boundary="0000000000005dd81d058a2a2b80" --0000000000005dd81d058a2a2b80 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you all for the help. Shall I create a JIRA case for adding optional cache manager to the API? Regards, Naveen On Thu, May 30, 2019 at 10:19 AM Yurui Zhou wrote: > Hi Owen: > > We already have C++ CacheStore implementation that supply file/stripe > level metadata. We would glad to contribute it back to community if the > proposal is approved. > > Thanks > Yurui > On 30 May 2019, 6:01 AM +0800, Owen O'Malley , > wrote: > > Inheritance, especially in C++ is very hard to maintain compatibility > across versions. > > > > Based on my experience on the Java side with LLAP, I=E2=80=99d suggest = adding an > optional cache manager than can be supplied to the reader. As Deepak says= , > there is already an interface for passing in the file tail. I=E2=80=99d s= uspect > that we should have an API to supply a cache (memory or local file based) > for: > > > > * file footer & tail > > * stripe footers > > * stripe statistics > > * row indexes > > * row data > > > > .. Owen > > > > > On May 29, 2019, at 5:12 AM, naveen mahadevuni > wrote: > > > > > > Hi, > > > > > > We are using ORC C++ API. We would like to be able to sub-class the O= RC > > > implementation classes such as ReaderImpl, StatisticsImpl, > > > StripeInformationImpl... The reason being, when ORC files are stored > on a > > > cloud store such as S3, we would like to have the metadata/statistics > > > stored on a file on local disk and create wrapper implementation > classes > > > which read metadata/statistics from locally stored file and delegates > only > > > the data stream reads to the cloud store. > > > > > > Will there be any problems if these implementation classes are > published? > > > > > > Thanks, > > > Naveen > --0000000000005dd81d058a2a2b80--