From dev-return-2687-archive-asf-public=cust-asf.ponee.io@orc.apache.org Thu Nov 29 23:48:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DEC7518066C for ; Thu, 29 Nov 2018 23:48:04 +0100 (CET) Received: (qmail 99875 invoked by uid 500); 29 Nov 2018 22:48:04 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 99856 invoked by uid 99); 29 Nov 2018 22:48:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2018 22:48:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8725FD0E83 for ; Thu, 29 Nov 2018 22:48:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ibDVw-n-jz3F for ; Thu, 29 Nov 2018 22:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E59FC610D8 for ; Thu, 29 Nov 2018 22:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E5D41E25B0 for ; Thu, 29 Nov 2018 22:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6736224DD7 for ; Thu, 29 Nov 2018 22:48:00 +0000 (UTC) Date: Thu, 29 Nov 2018 22:48:00 +0000 (UTC) From: "Fang Zheng (JIRA)" To: dev@orc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ORC-442) [C++] Code improvements in Statistics and Writer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Fang Zheng created ORC-442: ------------------------------ Summary: [C++] Code improvements in Statistics and Writer Key: ORC-442 URL: https://issues.apache.org/jira/browse/ORC-442 Project: ORC Issue Type: Improvement Components: C++ Reporter: Fang Zheng A few code changes in Statistics and Writer classes: 1. Change StatisticsImpl to use vector instead of list for storing ColumnStatistics. Because the required operations are push_back() in ctor, iteration in dtor, and random element access in getColumnStatistics(), and list does not support random access in constant time, vector would be more appropriate than list. 2. InternalBooleanStatistics is currently typedef-ed as InternalStatisticsImpl. Since min/max/sum does not apply to BooleanColumnStatistics, we should define InternalBooleanStatistics to be InternalStatisticsImpl to save 21 bytes per instance. 3. Misc. changes to ColumnWriter.hh, Writer.cc, Compression.hh, and Statistics.hh to fix typos in Doxygen and reduce object copies. Please see PR for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)