orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fang Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ORC-442) [C++] Code improvements in Statistics and Writer
Date Thu, 29 Nov 2018 22:48:00 GMT
Fang Zheng created ORC-442:
------------------------------

             Summary: [C++] Code improvements in Statistics and Writer
                 Key: ORC-442
                 URL: https://issues.apache.org/jira/browse/ORC-442
             Project: ORC
          Issue Type: Improvement
          Components: C++
            Reporter: Fang Zheng


A few code changes in Statistics and Writer classes:

1. Change StatisticsImpl to use vector instead of list for storing ColumnStatistics. Because
the required operations are push_back() in ctor, iteration in dtor, and random element access
in getColumnStatistics(), and list does not support random access in constant time, vector
would be more appropriate than list.

2.  InternalBooleanStatistics is currently typedef-ed as InternalStatisticsImpl<uint64_t>.
Since min/max/sum does not apply to BooleanColumnStatistics, we should define InternalBooleanStatistics
to be InternalStatisticsImpl<char> to save 21 bytes per instance.

3. Misc. changes to ColumnWriter.hh, Writer.cc, Compression.hh, and Statistics.hh to fix typos
in Doxygen and reduce object copies.

Please see PR for details.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message