From dev-return-2505-archive-asf-public=cust-asf.ponee.io@orc.apache.org Wed Aug 8 00:16:59 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E698D18078F for ; Wed, 8 Aug 2018 00:16:57 +0200 (CEST) Received: (qmail 74694 invoked by uid 500); 7 Aug 2018 22:16:57 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 74295 invoked by uid 99); 7 Aug 2018 22:16:56 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 22:16:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 22865E0A03; Tue, 7 Aug 2018 22:16:56 +0000 (UTC) From: omalley To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc pull request #299: ORC-203 - Update StringStatistics to trim long string... Content-Type: text/plain Message-Id: <20180807221656.22865E0A03@git1-us-west.apache.org> Date: Tue, 7 Aug 2018 22:16:56 +0000 (UTC) Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/299#discussion_r208397080 --- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java --- @@ -584,16 +630,40 @@ public void merge(ColumnStatisticsImpl other) { if (str.minimum != null) { maximum = new Text(str.getMaximum()); minimum = new Text(str.getMinimum()); - } else { + } --- End diff -- Ok, you should keep the "else" on the same line as the "}", but I don't think you need this new branch. ---