orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #299: ORC-203 - Update StringStatistics to trim long string...
Date Tue, 07 Aug 2018 22:16:36 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/299#discussion_r208392450
  
    --- Diff: java/core/src/java/org/apache/orc/StringColumnStatistics.java ---
    @@ -33,6 +33,20 @@
        */
       String getMaximum();
     
    +  /**
    +   * Get the string with
    +   * length = Min(StringStatisticsImpl.MAX_BYTES_RECORDED, getMinimum())
    --- End diff --
    
    I would phrase this as "Get the lower bound of the values in this column. The value may
be truncated to at most MAX_BYTES_RECORDED."


---

Mime
View raw message