orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From moresandeep <...@git.apache.org>
Subject [GitHub] orc pull request #292: ORC-203 - Update StringStatistics to trim long string...
Date Fri, 27 Jul 2018 18:46:50 GMT
Github user moresandeep commented on a diff in the pull request:

    https://github.com/apache/orc/pull/292#discussion_r205867014
  
    --- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java ---
    @@ -584,16 +642,40 @@ public void merge(ColumnStatisticsImpl other) {
               if (str.minimum != null) {
                 maximum = new Text(str.getMaximum());
                 minimum = new Text(str.getMinimum());
    -          } else {
    +          }
    +          /* str.minimum == null when lower bound set */
    +          else if (str.getLowerBound() != null) {
    +            minimum = new Text(str.getLowerBound());
    +            isLowerBoundSet = true;
    +
    +            /* check for upper bound before setting max */
    +            if (str.getUpperBound() != null) {
    +              maximum = new Text(str.getUpperBound());
    +              isUpperBoundSet = true;
    +            } else {
    +              maximum = new Text(str.getMaximum());
    +            }
    +          }
    +          else {
               /* both are empty */
                 maximum = minimum = null;
               }
             } else if (str.minimum != null) {
               if (minimum.compareTo(str.minimum) > 0) {
    -            minimum = new Text(str.getMinimum());
    +            if(str.getLowerBound() != null) {
    +              minimum = new Text(str.getLowerBound());
    +              isLowerBoundSet = true;
    +            } else {
    +              minimum = new Text(str.getMinimum());
    --- End diff --
    
    We could but there is really does not matter as this will be set just once, either true
or default false given this is an instance. Let me know if you feel otherwise I can update
it. 


---

Mime
View raw message