From dev-return-2370-archive-asf-public=cust-asf.ponee.io@orc.apache.org  Tue Jun  5 19:38:51 2018
Return-Path: <dev-return-2370-archive-asf-public=cust-asf.ponee.io@orc.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id BEC68180625
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  5 Jun 2018 19:38:50 +0200 (CEST)
Received: (qmail 75962 invoked by uid 500); 5 Jun 2018 17:38:49 -0000
Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@orc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@orc.apache.org>
List-Post: <mailto:dev@orc.apache.org>
List-Id: <dev.orc.apache.org>
Reply-To: dev@orc.apache.org
Delivered-To: mailing list dev@orc.apache.org
Received: (qmail 75951 invoked by uid 99); 5 Jun 2018 17:38:49 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2018 17:38:49 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id E8F70E04BC; Tue,  5 Jun 2018 17:38:48 +0000 (UTC)
From: majetideepak <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-277-orc@git.apache.org>
In-Reply-To: <git-pr-277-orc@git.apache.org>
Subject: [GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests
Content-Type: text/plain
Message-Id: <20180605173848.E8F70E04BC@git1-us-west.apache.org>
Date: Tue,  5 Jun 2018 17:38:48 +0000 (UTC)

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/277#discussion_r193159979
  
    --- Diff: c++/src/Compression.cc ---
    @@ -199,13 +199,16 @@ namespace orc {
                               uint64_t blockSize,
                               MemoryPool& pool);
     
    +    ~ZlibCompressionStream() { end(); }
    --- End diff --
    
    Thanks!


---