orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests
Date Tue, 05 Jun 2018 14:59:38 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/277#discussion_r193106126
  
    --- Diff: c++/test/CMakeLists.txt ---
    @@ -64,7 +64,12 @@ target_link_libraries (create-test-files
       protobuf
     )
     
    -add_test (NAME orc-test COMMAND orc-test)
    +if (TEST_VALGRIND_MEMCHECK)
    +  add_test (orc-test  
    --- End diff --
    
    You have trailing spaces here.


---

Mime
View raw message