orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #277: ORC-372: Enable valgrind for C++ travis-ci tests
Date Mon, 04 Jun 2018 23:42:04 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/277#discussion_r192907281
  
    --- Diff: c++/src/TypeImpl.cc ---
    @@ -258,31 +258,34 @@ namespace orc {
     
         case STRUCT: {
           StructVectorBatch *result = new StructVectorBatch(capacity, memoryPool);
    +      std::unique_ptr<ColumnVectorBatch> return_value = std::unique_ptr<ColumnVectorBatch>(result);
    --- End diff --
    
    maybe we can directly merge line 260 and 261 to a single statement. same for below.


---

Mime
View raw message